Stop passing raw pointers to DictionaryValue::Set, part 2

chrome/browser/chromeos/extensions/external_cache_unittest.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/chromeos/extensions/external_cache.h"
 
 #include <map>
 #include <set>
 #include <string>
 #include <utility>
@@ skipping 98 matching lines @@
   void CreateFile(const base::FilePath& file) {
     EXPECT_EQ(base::WriteFile(file, NULL, 0), 0);
   }
 
   base::FilePath GetExtensionFile(const base::FilePath& dir,
                                   const std::string& id,
                                   const std::string& version) {
     return dir.Append(id + "-" + version + ".crx");
   }
 
-  base::DictionaryValue* CreateEntryWithUpdateUrl(bool from_webstore) {
-    base::DictionaryValue* entry = new base::DictionaryValue;
+  std::unique_ptr<base::DictionaryValue> CreateEntryWithUpdateUrl(
+      bool from_webstore) {
+    auto entry = base::MakeUnique<base::DictionaryValue>();
     entry->SetString(extensions::ExternalProviderImpl::kExternalUpdateUrl,
         from_webstore ? extension_urls::GetWebstoreUpdateUrl().spec()
                       : kNonWebstoreUpdateUrl);
     return entry;
   }
 
   void WaitForCompletion() {
     // Wait for background task completion that sends replay to UI thread.
     pool_owner_->pool()->FlushForTesting();
     // Wait for UI thread task completion.
@@ skipping 24 matching lines @@
 
   DISALLOW_COPY_AND_ASSIGN(ExternalCacheTest);
 };
 
 TEST_F(ExternalCacheTest, Basic) {
   base::FilePath cache_dir(CreateCacheDir(false));
   ExternalCache external_cache(cache_dir, request_context_getter(),
       background_task_runner(), this, true, false);
 
   std::unique_ptr<base::DictionaryValue> prefs(new base::DictionaryValue);
-  base::DictionaryValue* dict = CreateEntryWithUpdateUrl(true);
-  prefs->Set(kTestExtensionId1, dict);
+  prefs->Set(kTestExtensionId1, CreateEntryWithUpdateUrl(true));
   CreateExtensionFile(cache_dir, kTestExtensionId1, "1");
-  dict = CreateEntryWithUpdateUrl(true);
-  prefs->Set(kTestExtensionId2, dict);
+  prefs->Set(kTestExtensionId2, CreateEntryWithUpdateUrl(true));
   prefs->Set(kTestExtensionId3, CreateEntryWithUpdateUrl(false));
   CreateExtensionFile(cache_dir, kTestExtensionId3, "3");
   prefs->Set(kTestExtensionId4, CreateEntryWithUpdateUrl(false));
 
   external_cache.UpdateExtensionsList(std::move(prefs));
   WaitForCompletion();
 
   ASSERT_TRUE(provided_prefs());
   EXPECT_EQ(provided_prefs()->size(), 2ul);
 
@@ skipping 121 matching lines @@
   ASSERT_TRUE(provided_prefs()->GetDictionary(kTestExtensionId1, &entry1));
   EXPECT_TRUE(entry1->HasKey(
       extensions::ExternalProviderImpl::kExternalUpdateUrl));
   EXPECT_FALSE(entry1->HasKey(
       extensions::ExternalProviderImpl::kExternalCrx));
   EXPECT_FALSE(entry1->HasKey(
       extensions::ExternalProviderImpl::kExternalVersion));
 }
 
 }  // namespace chromeos