chrome/browser/media/android/cdm/media_drm_storage_factory.h - Issue 2765343003: media: Add MediaDrmStorage

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/media/android/cdm/media_drm_storage_factory.h

Issue 2765343003: media: Add MediaDrmStorage (Closed)

Patch Set: fix compile error Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/browser/chrome_content_browser_client.cc ('K') | « chrome/browser/chrome_content_browser_client.cc ('k') | chrome/browser/media/android/cdm/media_drm_storage_factory.cc » ('j') | chrome/browser/media/android/cdm/media_drm_storage_factory.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 // Copyright 2017 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef CHROME_BROWSER_MEDIA_ANDROID_CDM_MEDIA_DRM_STORAGE_FACTORY_H_

	6 #define CHROME_BROWSER_MEDIA_ANDROID_CDM_MEDIA_DRM_STORAGE_FACTORY_H_

	7

	8 #include "media/mojo/interfaces/media_drm_storage.mojom.h"

	9

	10 namespace content {

	11 class RenderFrameHost;

	12 }

	13

	14 namespace chrome {

	15

	16 void CreateMediaDrmStorage(content::RenderFrameHost* render_frame_host,
	liberato (no reviews please) 2017/03/28 16:42:44 i think that the answer to my question is 'leave i i think that the answer to my question is 'leave it as is'. however, here's the discussion that went on in my head. :) should this be exposed on RFH directly? all of the other interfaces are visible in content/ already. of course, RFH would need to ask the embedder to provide the concrete impl. do we believe that the interfaces in media/ are applicable to any embedder? seems like the answer should be 'yes'. xhwang 2017/03/29 20:47:25 We discussed this offline. The idea of this commen Show quoted text On 2017/03/28 16:42:44, liberato wrote: > i think that the answer to my question is 'leave it as is'. however, here's the > discussion that went on in my head. :) > > should this be exposed on RFH directly? all of the other interfaces are visible > in content/ already. of course, RFH would need to ask the embedder to provide > the concrete impl. > > do we believe that the interfaces in media/ are applicable to any embedder? > seems like the answer should be 'yes'. We discussed this offline. The idea of this comment is that we always register the service at the content layer, then use ContentClient to delegate the concrete work to the content embedder. It's totally doable. But currently we already have a lot of layers. Adding this indirection doesn't seem to bring us any obvious benefits. So for now I'll leave this as is, but we can always revisit this idea.
	17 media::mojom::MediaDrmStorageRequest request);

	18

	19 } // namespace chrome

	20

	21 #endif // CHROME_BROWSER_MEDIA_ANDROID_CDM_MEDIA_DRM_STORAGE_FACTORY_H_

OLD	NEW