Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Issue 2765343002: Always apply new type arguments in InterfaceTypeImpl.substitute2(). (Closed)

Created:
3 years, 9 months ago by scheglov
Modified:
3 years, 9 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Always apply new type arguments in InterfaceTypeImpl.substitute2(). As with the previous part of this problem, the fact that a type parameter is not used, does not let us no keep it in type arguments when we instantiate the type. We still need to replace all type parameters with current type arguments. R=brianwilkerson@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/74d6957b4fa7c2c74004cf2a8dc15ac743841d90

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M pkg/analyzer/lib/src/dart/element/type.dart View 2 chunks +0 lines, -4 lines 0 comments Download
M pkg/analyzer/test/src/summary/top_level_inference_test.dart View 2 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
scheglov
3 years, 9 months ago (2017-03-22 18:11:54 UTC) #1
Brian Wilkerson
lgtm
3 years, 9 months ago (2017-03-22 18:29:30 UTC) #2
scheglov
3 years, 9 months ago (2017-03-22 18:36:08 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
74d6957b4fa7c2c74004cf2a8dc15ac743841d90 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698