Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(222)

Issue 276523003: Password bubble: Explicitly disable on non-Aura platforms. (Closed)

Created:
6 years, 7 months ago by Mike West
Modified:
6 years, 7 months ago
Reviewers:
Patrick Dubroy
CC:
chromium-reviews, mkwst+watchlist_chromium.org
Visibility:
Public.

Description

Password bubble: Explicitly disable on non-Aura platforms. We don't offer the flag on non-Aura platforms, but it's certainly possible for a user to enter the CLI flag manually. We'd prefer not to crash in that case. BUG=261628 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=269557

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -3 lines) Patch
M chrome/browser/password_manager/chrome_password_manager_client.cc View 2 chunks +5 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Mike West
Hey Patrick, mind stamping this fairly trivial change? -mike
6 years, 7 months ago (2014-05-09 07:50:14 UTC) #1
Patrick Dubroy
lgtm
6 years, 7 months ago (2014-05-09 07:54:14 UTC) #2
Mike West
The CQ bit was checked by mkwst@chromium.org
6 years, 7 months ago (2014-05-09 07:55:21 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mkwst@chromium.org/276523003/1
6 years, 7 months ago (2014-05-09 08:02:35 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-09 09:31:54 UTC) #5
commit-bot: I haz the power
6 years, 7 months ago (2014-05-10 07:51:58 UTC) #6
Message was sent while issue was closed.
Change committed as 269557

Powered by Google App Engine
This is Rietveld 408576698