Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Issue 2765223002: Change code to determine ANSI support on Windows (Closed)

Created:
3 years, 9 months ago by karlklose
Modified:
3 years, 9 months ago
Reviewers:
zra, ahe
CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : Address comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -26 lines) Patch
M pkg/front_end/lib/src/fasta/colors.dart View 1 3 chunks +37 lines, -26 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
karlklose
3 years, 9 months ago (2017-03-22 11:53:50 UTC) #2
ahe
lgtm https://codereview.chromium.org/2765223002/diff/1/pkg/front_end/lib/src/fasta/colors.dart File pkg/front_end/lib/src/fasta/colors.dart (right): https://codereview.chromium.org/2765223002/diff/1/pkg/front_end/lib/src/fasta/colors.dart#newcode100 pkg/front_end/lib/src/fasta/colors.dart:100: // implement `ansiSupported`. ansiSupported -> supportsAnsiEscapes. https://codereview.chromium.org/2765223002/diff/1/pkg/front_end/lib/src/fasta/colors.dart#newcode149 pkg/front_end/lib/src/fasta/colors.dart:149: ...
3 years, 9 months ago (2017-03-22 12:05:36 UTC) #3
karlklose
3 years, 9 months ago (2017-03-22 12:20:53 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
4d3719f54ebe5a50fd814d7be27b148a4c88a8e1 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698