Chromium Code Reviews| Index: third_party/WebKit/Source/core/editing/spellcheck/SpellChecker.cpp |
| diff --git a/third_party/WebKit/Source/core/editing/spellcheck/SpellChecker.cpp b/third_party/WebKit/Source/core/editing/spellcheck/SpellChecker.cpp |
| index 71e68bdd067ebc8a48f1c32ea36e862e47bed2f0..120d0f244ac4df080224f38d0047cad9ffc10689 100644 |
| --- a/third_party/WebKit/Source/core/editing/spellcheck/SpellChecker.cpp |
| +++ b/third_party/WebKit/Source/core/editing/spellcheck/SpellChecker.cpp |
| @@ -302,9 +302,8 @@ void SpellChecker::advanceToNextMisspelling(bool startBeforeSelection) { |
| .build()); |
| frame().selection().revealSelection(); |
| spellCheckerClient().updateSpellingUIWithMisspelledWord(misspelledWord); |
| - frame().document()->markers().addMarker(misspellingRange.startPosition(), |
| - misspellingRange.endPosition(), |
| - DocumentMarker::Spelling); |
| + frame().document()->markers().addSpellingMarker( |
| + misspellingRange.startPosition(), misspellingRange.endPosition()); |
| } |
| } |
| @@ -548,8 +547,15 @@ static void addMarker(Document* document, |
| return; |
| if (!SpellChecker::isSpellCheckingEnabledAt(rangeToMark.endPosition())) |
| return; |
| - document->markers().addMarker(rangeToMark.startPosition(), |
| - rangeToMark.endPosition(), type, description); |
| + |
| + DCHECK(type == DocumentMarker::Grammar || type == DocumentMarker::Spelling); |
|
yosin_UTC9
2017/03/30 01:48:57
nit: Could you add |<< type| for ease of debugging
|
| + if (type == DocumentMarker::Grammar) { |
| + document->markers().addGrammarMarker( |
| + rangeToMark.startPosition(), rangeToMark.endPosition(), description); |
| + } else { |
| + document->markers().addSpellingMarker( |
| + rangeToMark.startPosition(), rangeToMark.endPosition(), description); |
| + } |
| } |
| void SpellChecker::markAndReplaceFor( |