Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(219)

Unified Diff: third_party/WebKit/Source/core/editing/markers/DocumentMarkerController.h

Issue 2765133002: [WIP] Add DocumentMarkerController::addGrammarMarker() and addSpellingMarker() (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/editing/markers/DocumentMarkerController.h
diff --git a/third_party/WebKit/Source/core/editing/markers/DocumentMarkerController.h b/third_party/WebKit/Source/core/editing/markers/DocumentMarkerController.h
index af697ab3b8a72cd1b2625d552a7755ec065558e5..220c08c83f1280bd1613af6fe8b94e843217fb0a 100644
--- a/third_party/WebKit/Source/core/editing/markers/DocumentMarkerController.h
+++ b/third_party/WebKit/Source/core/editing/markers/DocumentMarkerController.h
@@ -54,16 +54,19 @@ class CORE_EXPORT DocumentMarkerController final
void clear();
void addMarker(Node*, DocumentMarker*);
- void addMarker(const Position& start,
- const Position& end,
- DocumentMarker::MarkerType,
- const String& description = emptyString);
- void addTextMatchMarker(const EphemeralRange&, bool activeMatch);
Xiaocheng 2017/03/22 02:00:29 nit: Shouldn't move this line.
+
void addCompositionMarker(const Position& start,
const Position& end,
Color underlineColor,
bool thick,
Color backgroundColor);
+ void addGrammarMarker(const Position& start,
+ const Position& end,
+ const String& description = emptyString);
+ void addSpellingMarker(const Position& start,
+ const Position& end,
+ const String& description = emptyString);
+ void addTextMatchMarker(const EphemeralRange&, bool activeMatch);
void copyMarkers(Node* srcNode,
unsigned startOffset,
@@ -135,6 +138,10 @@ class CORE_EXPORT DocumentMarkerController final
private:
using MarkerMap = HeapHashMap<WeakMember<Node>, Member<DocumentMarkerList>>;
+ void addGrammarOrSpellingMarker(const Position& start,
+ const Position& end,
+ DocumentMarker::MarkerType,
+ const String& description);
DocumentMarkerList* createMarkerListOfType(DocumentMarker::MarkerType);
HeapVector<Member<DocumentMarkerList>> getMarkerListsForNode(
Node*,

Powered by Google App Engine
This is Rietveld 408576698