Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(69)

Issue 2765063002: Introducing `IdeOptions`. (Closed)

Created:
3 years, 9 months ago by pquitslund
Modified:
3 years, 9 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Introducing `IdeOptions`. * add simple `IdeOptions` class * remove unused `ServerOptions` R=brianwilkerson@google.com See: https://github.com/flutter/flutter-intellij/issues/463 Committed: https://github.com/dart-lang/sdk/commit/d95508183dac68aa389361071d7fcdc7d2352556

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -171 lines) Patch
M pkg/analysis_server/lib/src/analysis_server.dart View 5 chunks +12 lines, -5 lines 0 comments Download
A pkg/analysis_server/lib/src/ide_options.dart View 1 chunk +18 lines, -0 lines 0 comments Download
D pkg/analysis_server/lib/src/server_options.dart View 1 chunk +0 lines, -118 lines 0 comments Download
D pkg/analysis_server/test/server_options_test.dart View 1 chunk +0 lines, -46 lines 0 comments Download
M pkg/analysis_server/test/test_all.dart View 2 chunks +0 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
pquitslund
3 years, 9 months ago (2017-03-21 20:53:10 UTC) #2
Brian Wilkerson
lgtm
3 years, 9 months ago (2017-03-21 20:58:08 UTC) #3
pquitslund
3 years, 9 months ago (2017-03-21 21:48:34 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
d95508183dac68aa389361071d7fcdc7d2352556 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698