Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(180)

Side by Side Diff: third_party/WebKit/Source/core/dom/CompositorProxy.h

Issue 2765053002: Avoid exposing cc::Layer tree to CompositorProxy (Closed)
Patch Set: Minor changes Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CompositorProxy_h 5 #ifndef CompositorProxy_h
6 #define CompositorProxy_h 6 #define CompositorProxy_h
7 7
8 #include "bindings/core/v8/ScriptWrappable.h" 8 #include "bindings/core/v8/ScriptWrappable.h"
9 #include "core/CoreExport.h" 9 #include "core/CoreExport.h"
10 #include "core/dom/CompositorProxyClient.h" 10 #include "core/dom/CompositorProxyClient.h"
(...skipping 20 matching lines...) Expand all
31 const Vector<String>& attributeArray, 31 const Vector<String>& attributeArray,
32 ExceptionState&); 32 ExceptionState&);
33 static CompositorProxy* create(ExecutionContext*, 33 static CompositorProxy* create(ExecutionContext*,
34 uint64_t element, 34 uint64_t element,
35 uint32_t compositorMutableProperties); 35 uint32_t compositorMutableProperties);
36 virtual ~CompositorProxy(); 36 virtual ~CompositorProxy();
37 37
38 DEFINE_INLINE_TRACE() {} 38 DEFINE_INLINE_TRACE() {}
39 39
40 uint64_t elementId() const { return m_elementId; } 40 uint64_t elementId() const { return m_elementId; }
41 uint64_t proxyId() const { return m_proxyId; }
41 uint32_t compositorMutableProperties() const { 42 uint32_t compositorMutableProperties() const {
42 return m_compositorMutableProperties; 43 return m_compositorMutableProperties;
43 } 44 }
44 bool supports(const String& attribute) const; 45 bool supports(const String& attribute) const;
45 46
46 bool initialized() const { return m_connected && m_state.get(); } 47 bool initialized() const { return m_connected && m_state.get(); }
47 bool connected() const { return m_connected; } 48 bool connected() const { return m_connected; }
48 void disconnect(); 49 void disconnect();
49 50
50 double opacity(ExceptionState&) const; 51 double opacity(ExceptionState&) const;
(...skipping 14 matching lines...) Expand all
65 CompositorProxy(uint64_t element, 66 CompositorProxy(uint64_t element,
66 uint32_t compositorMutableProperties, 67 uint32_t compositorMutableProperties,
67 CompositorProxyClient*); 68 CompositorProxyClient*);
68 69
69 private: 70 private:
70 bool raiseExceptionIfNotMutable(uint32_t compositorMutableProperty, 71 bool raiseExceptionIfNotMutable(uint32_t compositorMutableProperty,
71 ExceptionState&) const; 72 ExceptionState&) const;
72 void disconnectInternal(); 73 void disconnectInternal();
73 74
74 const uint64_t m_elementId = 0; 75 const uint64_t m_elementId = 0;
76 const uint64_t m_proxyId = 0;
flackr 2017/04/03 17:09:19 Do we need proxyId? Can we not key off of elementI
smcgruer 2017/04/03 17:57:31 Is there not a N:1 relationship between Compositor
flackr 2017/04/11 17:51:36 At least there is in the current implementation wh
75 const uint32_t m_compositorMutableProperties = 0; 77 const uint32_t m_compositorMutableProperties = 0;
76 78
77 bool m_connected = true; 79 bool m_connected = true;
78 CrossThreadPersistent<CompositorProxyClient> m_client; 80 CrossThreadPersistent<CompositorProxyClient> m_client;
79 std::unique_ptr<CompositorMutableState> m_state; 81 std::unique_ptr<CompositorMutableState> m_state;
80 }; 82 };
81 83
82 } // namespace blink 84 } // namespace blink
83 85
84 #endif // CompositorProxy_h 86 #endif // CompositorProxy_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698