Issue 2765002: Automatically append FLAKY_ and FAILS_ prefixes to gtest_filters....

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 2765002: Automatically append FLAKY_ and FAILS_ prefixes to gtest_filters.... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
4 years, 11 months ago by Timur Iskhodzhanov

Modified:
3 years, 11 months ago

Reviewers:
Lei Zhang, Alexander Potapenko, Evan Martin, Paweł Hajdan Jr.

CC:
chromium-reviews, Timur Iskhodzhanov, stuartmorgan, pam+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

[GTTF] Automatically append FLAKY_ and FAILS_ prefixes to gtest_filters. TEST=none BUG=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=49240

Patch Set 1 #

Patch Set 2 : '' #

Created: 4 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+24 lines, -13 lines)			Patch
M	chrome/test/data/valgrind/ui_tests.gtest_linux.txt	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/test/data/valgrind/ui_tests.gtest_mac.txt	View	1	3 chunks	+12 lines, -12 lines	0 comments	Download
M	tools/valgrind/chrome_tests.py	View		1 chunk	+11 lines, -0 lines	0 comments	Download

Trybot results:

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Paweł Hajdan Jr.

LGTM I've updated the commit message to include the GTTF prefix (because it'll be good ...

4 years, 11 months ago (2010-06-09 09:03:36 UTC) #2

Alexander Potapenko

4 years, 11 months ago (2010-06-09 09:09:20 UTC) #3

On 2010/06/09 09:03:36, Paweł Hajdan Jr. wrote:
> LGTM
> 
> I've updated the commit message to include the GTTF prefix (because it'll be
> good for Greener Tree, thanks!).

LGTM

Expand Messages | Collapse Messages