Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3530)

Unified Diff: chrome/installer/setup/uninstall.cc

Issue 2764963002: Move ProgID methods from BrowserDistribution into install_static. (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/installer/setup/uninstall.cc
diff --git a/chrome/installer/setup/uninstall.cc b/chrome/installer/setup/uninstall.cc
index d0122073df81bbf1d6b48c7f95c5e99135427759..1ec5d4dd0c36ae69dd2e19df8615b1cff648a307 100644
--- a/chrome/installer/setup/uninstall.cc
+++ b/chrome/installer/setup/uninstall.cc
@@ -440,9 +440,8 @@ void RemoveFiletypeRegistration(const InstallerState& installer_state,
base::string16 classes_path(ShellUtil::kRegClasses);
classes_path.push_back(base::FilePath::kSeparators[0]);
- BrowserDistribution* distribution = BrowserDistribution::GetDistribution();
- const base::string16 prog_id(
- distribution->GetBrowserProgIdPrefix() + browser_entry_suffix);
+ const base::string16 prog_id(install_static::GetProgIdPrefix() +
+ browser_entry_suffix);
// Delete each filetype association if it references this Chrome. Take care
// not to delete the association if it references a system-level install of
@@ -639,8 +638,9 @@ bool DeleteChromeRegistrationKeys(const InstallerState& installer_state,
base::FilePath chrome_exe(installer_state.target_path().Append(kChromeExe));
// Delete Software\Classes\ChromeHTML.
- const base::string16 prog_id(
- dist->GetBrowserProgIdPrefix() + browser_entry_suffix);
+ DCHECK_EQ(BrowserDistribution::GetDistribution(), dist);
huangs 2017/03/21 15:35:48 |dist| gets used on line 632. Move the DCHECK ther
grt (UTC plus 2) 2017/03/22 08:03:36 I have it here because it's relevant for the call
+ const base::string16 prog_id(install_static::GetProgIdPrefix() +
+ browser_entry_suffix);
base::string16 reg_prog_id(ShellUtil::kRegClasses);
reg_prog_id.push_back(base::FilePath::kSeparators[0]);
reg_prog_id.append(prog_id);

Powered by Google App Engine
This is Rietveld 408576698