Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Unified Diff: build/android/resource_sizes.py

Issue 2764913002: Add optional --no-static-initializer-check to resource_sizes.py (Closed)
Patch Set: remove double negative in flag variable usage Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/android/resource_sizes.py
diff --git a/build/android/resource_sizes.py b/build/android/resource_sizes.py
index dd007bd2275ffb8d2585df762930b1573ed432cb..89e7dca11a3453f01c61ba09e0c95601511f8534 100755
--- a/build/android/resource_sizes.py
+++ b/build/android/resource_sizes.py
@@ -736,6 +736,9 @@ def main():
argparser.add_argument('--no-output-dir', action='store_true',
help='Skip all measurements that rely on having '
'output-dir')
+ argparser.add_argument('--no-static-initializer-check', action='store_false',
+ dest='static_initializer_check', default=True,
+ help='Skip checking for static initializers')
argparser.add_argument('-d', '--device',
help='Dummy option for perf runner.')
argparser.add_argument('--estimate-patch-size', action='store_true',
@@ -772,8 +775,9 @@ def main():
args.reference_apk_bucket, chartjson=chartjson)
if not args.no_output_dir:
PrintPakAnalysis(args.apk, args.min_pak_resource_size)
- _PrintStaticInitializersCountFromApk(
- args.apk, tools_prefix, chartjson=chartjson)
+ if args.static_initializer_check:
+ _PrintStaticInitializersCountFromApk(
+ args.apk, tools_prefix, chartjson=chartjson)
if chartjson:
results_path = os.path.join(args.output_dir, 'results-chart.json')
logging.critical('Dumping json to %s', results_path)
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698