Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(185)

Unified Diff: components/data_use_measurement/core/data_use_measurement.cc

Issue 2764893003: Record data use of favicon (Closed)
Patch Set: fix tryjob Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/data_use_measurement/core/data_use_measurement.cc
diff --git a/components/data_use_measurement/core/data_use_measurement.cc b/components/data_use_measurement/core/data_use_measurement.cc
index 0e2794cf1902ff550dfec6b2a861e4027719be8f..fcebeb8d070d079520f1ebde9a28275fcd20bc27 100644
--- a/components/data_use_measurement/core/data_use_measurement.cc
+++ b/components/data_use_measurement/core/data_use_measurement.cc
@@ -17,6 +17,7 @@
#include "net/base/network_change_notifier.h"
#include "net/base/upload_data_stream.h"
#include "net/http/http_response_headers.h"
+#include "net/http/http_status_code.h"
#include "net/url_request/url_request.h"
#if defined(OS_ANDROID)
@@ -65,6 +66,17 @@ void IncrementLatencyHistogramByCount(const std::string& name,
}
#endif
+void RecordFavIconDataUse(const net::URLRequest& request) {
+ UMA_HISTOGRAM_COUNTS_100000(
+ "DataUse.FavIcon.Downstream",
+ request.was_cached() ? 0 : request.GetTotalReceivedBytes());
+ if (request.status().is_success() &&
+ request.GetResponseCode() != net::HTTP_OK) {
+ UMA_HISTOGRAM_COUNTS_100000("DataUse.FavIcon.Downstream.Non200Response",
+ request.GetTotalReceivedBytes());
+ }
+}
+
} // namespace
DataUseMeasurement::DataUseMeasurement(
@@ -132,6 +144,8 @@ void DataUseMeasurement::OnBeforeRedirect(const net::URLRequest& request,
// TODO(rajendrant): May not be needed when http://crbug/651957 is fixed.
UpdateDataUsePrefs(request);
ReportServicesMessageSizeUMA(request);
+ if (url_request_classifier_->IsFavIconRequest(request))
+ RecordFavIconDataUse(request);
}
void DataUseMeasurement::OnHeadersReceived(
@@ -173,6 +187,8 @@ void DataUseMeasurement::OnCompleted(const net::URLRequest& request,
#if defined(OS_ANDROID)
MaybeRecordNetworkBytesOS();
#endif
+ if (url_request_classifier_->IsFavIconRequest(request))
+ RecordFavIconDataUse(request);
}
void DataUseMeasurement::ReportDataUseUMA(const net::URLRequest& request,

Powered by Google App Engine
This is Rietveld 408576698