Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1104)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: components/data_use_measurement/core/url_request_classifier.h

Issue 2764893003: Record data use of favicon (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« components/data_use_measurement/content/content_url_request_classifier.h ('K') | « components/data_use_measurement/core/data_use_measurement.cc ('k') | tools/metrics/histograms/histograms.xml » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/data_use_measurement/core/url_request_classifier.h
diff --git a/components/data_use_measurement/core/url_request_classifier.h b/components/data_use_measurement/core/url_request_classifier.h
index 00dc4108054d5fd723980014da28554971206813..5ca43220f31c2dbdbf801de2484d2cbddc4df6ca 100644
--- a/components/data_use_measurement/core/url_request_classifier.h
+++ b/components/data_use_measurement/core/url_request_classifier.h
@@ -28,6 +28,9 @@ class URLRequestClassifier {
virtual DataUseUserData::DataUseContentType GetContentType(
const net::URLRequest& request,
const net::HttpResponseHeaders& response_headers) const = 0;
+
+ // Returns true if the URLRequest |request| belongs to favicon.
RyanSturm 2017/03/22 22:00:26 "Returns true if |request| is fetching a favicon."
Raj 2017/03/23 17:06:46 Done.
+ virtual bool IsFavIconRequest(const net::URLRequest& request) const = 0;
};
} // namespace data_use_measurement
« components/data_use_measurement/content/content_url_request_classifier.h ('K') | « components/data_use_measurement/core/data_use_measurement.cc ('k') | tools/metrics/histograms/histograms.xml » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698