Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issue 2764883002: [Win] safebrowsing: remove disable warnings compile flag (Closed)

Created:
3 years, 9 months ago by timvolodine
Modified:
3 years, 8 months ago
Reviewers:
Nathan Parker
CC:
chromium-reviews, grt+watch_chromium.org, vakh+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[Win] safebrowsing: remove disable warnings compile flag crbug.com/702773 (size_t to int conversions) has been fixed so the compile flag /wd4267 can be removed. BUG=700351

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -3 lines) Patch
M components/safe_browsing/renderer/BUILD.gn View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 9 (6 generated)
timvolodine
3 years, 9 months ago (2017-03-21 14:47:56 UTC) #6
timvolodine
On 2017/03/21 14:47:56, timvolodine wrote: oh, hold on, still errors on the bot, updated crbug
3 years, 9 months ago (2017-03-21 14:49:38 UTC) #7
timvolodine
3 years, 8 months ago (2017-03-30 16:26:39 UTC) #8
On 2017/03/21 14:49:38, timvolodine wrote:
> On 2017/03/21 14:47:56, timvolodine wrote:
> 
> oh, hold on, still errors on the bot, updated crbug

closing, because the issue was addressed in
https://codereview.chromium.org/2770493004

Powered by Google App Engine
This is Rietveld 408576698