Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(448)

Unified Diff: ui/gl/gl_surface_format.h

Issue 2764853002: gl: Remove redundant methods/variables from GLSurfaceFormat (Closed)
Patch Set: Replaced format.IsDefault() check with format.IsCompatible(GLSurfaceFormat()) Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ui/gl/gl_surface_egl.cc ('k') | ui/gl/gl_surface_format.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/gl/gl_surface_format.h
diff --git a/ui/gl/gl_surface_format.h b/ui/gl/gl_surface_format.h
index 2fcf504f887b516cf9cb92054a8026910ac9a69d..27cda863fd06100987941417e8e409efd91aadd6 100644
--- a/ui/gl/gl_surface_format.h
+++ b/ui/gl/gl_surface_format.h
@@ -35,18 +35,6 @@ class GL_EXPORT GLSurfaceFormat {
~GLSurfaceFormat();
- // Helper method to determine if the format is unchanged from the
- // default at creation time. TODO(klausw): can this be removed?
- bool IsDefault();
-
- // Surfaceless appears as a format property for backwards
- // compatibility with the previous enum-based implementation.
- // TODO(klausw): consider removing it and/or merging it into the
- // pre-existing IsSurfaceless() predicate for the various Surface
- // subclasses?
- void SetIsSurfaceless();
- bool IsSurfaceless();
-
// A given pair of surfaces is considered compatible if glSetSurface
// can be used to switch between them without generating BAD_MATCH
// errors, visual errors, or gross inefficiency, and incompatible
@@ -80,9 +68,7 @@ class GL_EXPORT GLSurfaceFormat {
int GetBufferSize();
private:
- bool is_default_ = true;
SurfacePixelLayout pixel_layout_ = PIXEL_LAYOUT_DONT_CARE;
- bool is_surfaceless_ = false;
int red_bits_ = -1;
int green_bits_ = -1;
int blue_bits_ = -1;
« no previous file with comments | « ui/gl/gl_surface_egl.cc ('k') | ui/gl/gl_surface_format.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698