Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(196)

Issue 276483005: Extensions docs, declarativeWebRequest: notice being on hold (Closed)

Created:
6 years, 7 months ago by vabr (Chromium)
Modified:
6 years, 7 months ago
Reviewers:
Mike West, battre
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Visibility:
Public.

Description

Extensions docs, declarativeWebRequest: notice being on hold Because Declarative Web Request lacks an active owner at the moment, this CL adds a warning notice to the API's documentation site: "this API is currently on hold, without concrete plans to move to stable" Staged at https://chrome-apps-doc.appspot.com/_patch/276483005/extensions/declarativeWebRequest, but http://crbug.com/371402. Screenshots in my GDrive: https://drive.google.com/a/google.com/folderview?id=0Bx9cneu-k1RNeUZnRk5NWERObE0&usp=sharing (Google only, but let me know if you come from outside and need them). Original at https://developer.chrome.com/extensions/declarativeWebRequest BUG=112155 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=269567

Patch Set 1 #

Total comments: 1

Patch Set 2 : Now with boldface #

Total comments: 2

Patch Set 3 : Now stronger #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/common/extensions/api/declarative_web_request.json View 1 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (0 generated)
vabr (Chromium)
Hi Dominic, Is this what you had in mind? (Will send you screenshots in a ...
6 years, 7 months ago (2014-05-08 16:40:02 UTC) #1
vabr (Chromium)
Actually managed to share the screenshots through Chrome OS Files app: https://drive.google.com/a/google.com/folderview?id=0Bx9cneu-k1RNeUZnRk5NWERObE0&usp=sharing
6 years, 7 months ago (2014-05-08 16:47:44 UTC) #2
battre
LGTM https://codereview.chromium.org/276483005/diff/1/chrome/common/extensions/api/declarative_web_request.json File chrome/common/extensions/api/declarative_web_request.json (right): https://codereview.chromium.org/276483005/diff/1/chrome/common/extensions/api/declarative_web_request.json#newcode8 chrome/common/extensions/api/declarative_web_request.json:8: "description": "<em>Note: this API is currently on hold, ...
6 years, 7 months ago (2014-05-09 09:18:20 UTC) #3
vabr (Chromium)
Thanks, Dominic. Comment addressed and screenshots updated. Mike, Could you please add an OWNERS approval? ...
6 years, 7 months ago (2014-05-09 10:34:42 UTC) #4
Mike West
LGTM with one comment. https://codereview.chromium.org/276483005/diff/20001/chrome/common/extensions/api/declarative_web_request.json File chrome/common/extensions/api/declarative_web_request.json (right): https://codereview.chromium.org/276483005/diff/20001/chrome/common/extensions/api/declarative_web_request.json#newcode8 chrome/common/extensions/api/declarative_web_request.json:8: "description": "<em><b>Note:</b> this API is ...
6 years, 7 months ago (2014-05-09 10:45:30 UTC) #5
vabr (Chromium)
Thanks, Mike! Comment addressed, sending to the CQ. (I'm not going to complain about the ...
6 years, 7 months ago (2014-05-09 11:42:30 UTC) #6
vabr (Chromium)
The CQ bit was checked by vabr@chromium.org
6 years, 7 months ago (2014-05-09 11:42:35 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vabr@chromium.org/276483005/40001
6 years, 7 months ago (2014-05-09 11:45:05 UTC) #8
commit-bot: I haz the power
6 years, 7 months ago (2014-05-10 11:57:54 UTC) #9
Message was sent while issue was closed.
Change committed as 269567

Powered by Google App Engine
This is Rietveld 408576698