Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(479)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 276483004: Upstream accessibility tab switcher and related resources. (Closed)

Created:
6 years, 7 months ago by Bernhard Bauer
Modified:
6 years, 7 months ago
CC:
chromium-reviews, aboxhall+watch_chromium.org, yuzo+watch_chromium.org, plundblad+watch_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org
Visibility:
Public.

Description

Upstream accessibility tab switcher and related resources. BUG=318769 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=270178

Patch Set 1 #

Patch Set 2 : copyrights #

Patch Set 3 : sync #

Patch Set 4 : update #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+1100 lines, -13 lines) Patch
A + chrome/android/java/res/drawable/accessibility_tab_switcher_divider.xml View 1 2 chunks +5 lines, -4 lines 0 comments Download
A + chrome/android/java/res/drawable/ntp_toolbar_button_background.xml View 1 1 chunk +2 lines, -2 lines 0 comments Download
A + chrome/android/java/res/drawable/ntp_toolbar_button_background_selected.xml View 1 1 chunk +4 lines, -5 lines 0 comments Download
A chrome/android/java/res/layout/accessibility_tab_switcher.xml View 1 1 chunk +60 lines, -0 lines 0 comments Download
A chrome/android/java/res/layout/accessibility_tab_switcher_list_item.xml View 1 1 chunk +78 lines, -0 lines 0 comments Download
M chrome/android/java/res/values/colors.xml View 1 chunk +11 lines, -0 lines 1 comment Download
M chrome/android/java/res/values/dimens.xml View 1 chunk +6 lines, -0 lines 0 comments Download
A chrome/android/java/src/org/chromium/chrome/browser/widget/accessibility/AccessibilityTabModelAdapter.java View 1 1 chunk +148 lines, -0 lines 0 comments Download
A chrome/android/java/src/org/chromium/chrome/browser/widget/accessibility/AccessibilityTabModelListItem.java View 1 1 chunk +543 lines, -0 lines 0 comments Download
A chrome/android/java/src/org/chromium/chrome/browser/widget/accessibility/AccessibilityTabModelListView.java View 1 1 chunk +49 lines, -0 lines 0 comments Download
A chrome/android/java/src/org/chromium/chrome/browser/widget/accessibility/AccessibilityTabModelWrapper.java View 1 1 chunk +166 lines, -0 lines 0 comments Download
M chrome/android/java/strings/android_chrome_strings.grd View 1 chunk +28 lines, -2 lines 2 comments Download

Messages

Total messages: 11 (0 generated)
Bernhard Bauer
Please review. This is another pure move CL.
6 years, 7 months ago (2014-05-13 16:09:51 UTC) #1
Yaron
On 2014/05/13 16:09:51, Bernhard Bauer wrote: > Please review. This is another pure move CL. ...
6 years, 7 months ago (2014-05-13 16:30:46 UTC) #2
Yaron
On 2014/05/13 16:09:51, Bernhard Bauer wrote: > Please review. This is another pure move CL. ...
6 years, 7 months ago (2014-05-13 16:30:50 UTC) #3
Bernhard Bauer
The CQ bit was checked by bauerb@chromium.org
6 years, 7 months ago (2014-05-13 16:32:07 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bauerb@chromium.org/276483004/60001
6 years, 7 months ago (2014-05-13 16:32:21 UTC) #5
David Trainor- moved to gerrit
6 years, 7 months ago (2014-05-13 18:00:22 UTC) #6
David Trainor- moved to gerrit
On 2014/05/13 18:00:22, David Trainor wrote: We should rename this if it's being used for ...
6 years, 7 months ago (2014-05-13 18:21:25 UTC) #7
David Trainor- moved to gerrit
lgtm but let carson give the final signoff imo https://codereview.chromium.org/276483004/diff/60001/chrome/android/java/strings/android_chrome_strings.grd File chrome/android/java/strings/android_chrome_strings.grd (right): https://codereview.chromium.org/276483004/diff/60001/chrome/android/java/strings/android_chrome_strings.grd#newcode183 chrome/android/java/strings/android_chrome_strings.grd:183: ...
6 years, 7 months ago (2014-05-13 18:23:48 UTC) #8
clholgat
LGTM other than the comments https://codereview.chromium.org/276483004/diff/60001/chrome/android/java/res/values/colors.xml File chrome/android/java/res/values/colors.xml (right): https://codereview.chromium.org/276483004/diff/60001/chrome/android/java/res/values/colors.xml#newcode16 chrome/android/java/res/values/colors.xml:16: <color name="tab_title_bar_text_incognito">#FFFFFFFF</color> Looks like ...
6 years, 7 months ago (2014-05-13 18:36:37 UTC) #9
commit-bot: I haz the power
Change committed as 270178
6 years, 7 months ago (2014-05-13 19:52:41 UTC) #10
Bernhard Bauer
6 years, 7 months ago (2014-05-13 21:28:13 UTC) #11
Message was sent while issue was closed. 
On 2014/05/13 19:52:41, I haz the power (commit-bot) wrote:
> Change committed as 270178

Sorry, I only saw the comments after the CQ had landed the CL. I'll fix them in
a followup tomorrow.

https://codereview.chromium.org/276483004/diff/60001/chrome/android/java/stri...
File chrome/android/java/strings/android_chrome_strings.grd (right):

https://codereview.chromium.org/276483004/diff/60001/chrome/android/java/stri...
chrome/android/java/strings/android_chrome_strings.grd:183: Loading…
On 2014/05/13 18:23:48, David Trainor wrote:
> is that ... a single character?  Is that expected?  Just making sure!

AFAICT, it's a horizontal ellipsis
(http://www.fileformat.info/info/unicode/char/2026/index.htm).

Powered by Google App Engine
This is Rietveld 408576698