Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 276483002: Fix calculation of usable area of screen when VK is shown. (Closed)

Created:
6 years, 7 months ago by kevers
Modified:
6 years, 7 months ago
Reviewers:
oshima, bshe
CC:
chromium-reviews, kalyank, sadrul, ben+ash_chromium.org, bokan
Visibility:
Public.

Description

Fix calculation of usable area of screen when VK is shown. First part of a 2-sided patch to fix scroll-into-view with VK overscroll. BUG=370592 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=270092

Patch Set 1 #

Patch Set 2 : Add unit test #

Total comments: 6

Patch Set 3 : Fix nits #

Patch Set 4 : Fix unittests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+74 lines, -20 lines) Patch
M ash/root_window_controller_unittest.cc View 1 2 3 3 chunks +54 lines, -0 lines 0 comments Download
M ash/shell/keyboard_controller_proxy_stub.h View 1 2 3 1 chunk +1 line, -2 lines 0 comments Download
M ash/shell/keyboard_controller_proxy_stub.cc View 1 2 3 2 chunks +4 lines, -2 lines 0 comments Download
M chrome/browser/ui/ash/ash_keyboard_controller_proxy.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/ash/ash_keyboard_controller_proxy.cc View 1 2 chunks +0 lines, -12 lines 0 comments Download
M ui/keyboard/keyboard_controller_proxy.cc View 1 2 chunks +11 lines, -0 lines 0 comments Download
M ui/keyboard/keyboard_controller_unittest.cc View 1 2 3 2 chunks +4 lines, -3 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
kevers
Hey Biao, Can you please take a look at this CL.
6 years, 7 months ago (2014-05-08 14:09:50 UTC) #1
bshe
On 2014/05/08 14:09:50, kevers wrote: > Hey Biao, > > Can you please take a ...
6 years, 7 months ago (2014-05-08 16:47:28 UTC) #2
kevers
The CQ bit was checked by kevers@chromium.org
6 years, 7 months ago (2014-05-08 16:49:58 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kevers@chromium.org/276483002/1
6 years, 7 months ago (2014-05-08 16:55:06 UTC) #4
kevers
The CQ bit was unchecked by kevers@chromium.org
6 years, 7 months ago (2014-05-08 18:22:55 UTC) #5
kevers
+oshima for ui/ash OWNERS
6 years, 7 months ago (2014-05-08 18:23:33 UTC) #6
oshima
unit test?
6 years, 7 months ago (2014-05-08 18:36:31 UTC) #7
kevers
On 2014/05/08 18:36:31, oshima wrote: > unit test? Done. Required moving the size calculation to ...
6 years, 7 months ago (2014-05-09 16:24:42 UTC) #8
oshima
lgtm with nits https://codereview.chromium.org/276483002/diff/20001/ash/root_window_controller_unittest.cc File ash/root_window_controller_unittest.cc (right): https://codereview.chromium.org/276483002/diff/20001/ash/root_window_controller_unittest.cc#newcode633 ash/root_window_controller_unittest.cc:633: gfx::Rect& visible_rect() { const const ? ...
6 years, 7 months ago (2014-05-12 18:09:59 UTC) #9
kevers
https://codereview.chromium.org/276483002/diff/20001/ash/root_window_controller_unittest.cc File ash/root_window_controller_unittest.cc (right): https://codereview.chromium.org/276483002/diff/20001/ash/root_window_controller_unittest.cc#newcode633 ash/root_window_controller_unittest.cc:633: gfx::Rect& visible_rect() { On 2014/05/12 18:09:59, oshima wrote: > ...
6 years, 7 months ago (2014-05-13 00:07:48 UTC) #10
kevers
The CQ bit was checked by kevers@chromium.org
6 years, 7 months ago (2014-05-13 13:19:32 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kevers@chromium.org/276483002/60001
6 years, 7 months ago (2014-05-13 13:19:49 UTC) #12
commit-bot: I haz the power
6 years, 7 months ago (2014-05-13 14:44:26 UTC) #13
Message was sent while issue was closed. 
Change committed as 270092

Powered by Google App Engine
This is Rietveld 408576698