Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(409)

Issue 2764823002: Add representation for object values (Closed)

Created:
3 years, 9 months ago by zhivkag
Modified:
3 years, 9 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add representation for object values It also adds few operators for the Basic literals for testing purposes. BUG= R=kmillikin@google.com Committed: https://github.com/dart-lang/sdk/commit/80a334512adfa98ca98cd3db87327566d710fa2a

Patch Set 1 #

Total comments: 4

Patch Set 2 : Apply suggestions from CR #

Patch Set 3 : Add TODO for class representation naming #

Unified diffs Side-by-side diffs Delta from patch set Stats (+166 lines, -36 lines) Patch
M pkg/kernel/lib/interpreter/interpreter.dart View 1 2 4 chunks +166 lines, -36 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
zhivkag
3 years, 9 months ago (2017-03-21 08:40:48 UTC) #2
Kevin Millikin (Google)
LGTM. https://codereview.chromium.org/2764823002/diff/1/pkg/kernel/lib/interpreter/interpreter.dart File pkg/kernel/lib/interpreter/interpreter.dart (right): https://codereview.chromium.org/2764823002/diff/1/pkg/kernel/lib/interpreter/interpreter.dart#newcode140 pkg/kernel/lib/interpreter/interpreter.dart:140: return receiver.callMethod(node.name.name, argValue); We might choose the name ...
3 years, 9 months ago (2017-03-21 11:55:05 UTC) #3
zhivkag
https://codereview.chromium.org/2764823002/diff/1/pkg/kernel/lib/interpreter/interpreter.dart File pkg/kernel/lib/interpreter/interpreter.dart (right): https://codereview.chromium.org/2764823002/diff/1/pkg/kernel/lib/interpreter/interpreter.dart#newcode140 pkg/kernel/lib/interpreter/interpreter.dart:140: return receiver.callMethod(node.name.name, argValue); On 2017/03/21 11:55:05, Kevin Millikin (Google) ...
3 years, 9 months ago (2017-03-21 12:14:49 UTC) #4
zhivkag
3 years, 9 months ago (2017-03-21 12:17:52 UTC) #6
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
80a334512adfa98ca98cd3db87327566d710fa2a (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698