Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(741)

Unified Diff: ios/web/public/web_client.h

Issue 2764773002: Add CWVUserContentController which enables injecting JavaScripts. (Closed)
Patch Set: Apply new comments. Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | ios/web_view/BUILD.gn » ('j') | ios/web_view/internal/web_view_early_page_script_provider.mm » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ios/web/public/web_client.h
diff --git a/ios/web/public/web_client.h b/ios/web/public/web_client.h
index 5c59fd224dc524d7cefc203be4a0c4a20b50517c..86aece85cfac175732f59a7b8a96a2273954d496 100644
--- a/ios/web/public/web_client.h
+++ b/ios/web/public/web_client.h
@@ -108,6 +108,9 @@ class WebClient {
// Gives the embedder a chance to provide the JavaScript to be injected into
// the web view as early as possible. Result must not be nil.
+ //
+ // TODO(crbug.com/703964): Change the return value to NSArray<NSString*> to
+ // improve performance.
Eugene But (OOO till 7-30) 2017/03/22 15:08:50 nit: please remove extra spaces before "improve" t
Hiroshi Ichikawa 2017/03/23 02:18:40 Done.
virtual NSString* GetEarlyPageScript(BrowserState* browser_state) const;
// Informs the embedder that a certificate error has occurred. If
« no previous file with comments | « no previous file | ios/web_view/BUILD.gn » ('j') | ios/web_view/internal/web_view_early_page_script_provider.mm » ('J')

Powered by Google App Engine
This is Rietveld 408576698