ios/web_view/public/cwv_user_script.h - Issue 2764773002: Add CWVUserContentController which enables injecting JavaScripts.

Side by Side Diff: ios/web_view/public/cwv_user_script.h

Issue 2764773002: Add CWVUserContentController which enables injecting JavaScripts. (Closed)

Patch Set: Add license. Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

« ios/web_view/public/cwv_user_content_controller.h ('K') | « ios/web_view/public/cwv_user_content_controller.h ('k') | ios/web_view/public/cwv_web_view.h » ('j') | ios/web_view/public/cwv_web_view.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 // Copyright 2017 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4 #ifndef IOS_WEB_VIEW_PUBLIC_CWV_USER_SCRIPT_H_

	5 #define IOS_WEB_VIEW_PUBLIC_CWV_USER_SCRIPT_H_

	6

	7 #import <Foundation/Foundation.h>

	8

	9 // User Script to be injected into main frame of CWVWebView after

	10 // window.document is created, but before other content is

	11 // loaded (i.e., at the same timing as
	michaeldo 2017/03/21 16:12:35 please re-wrap this comment please re-wrap this comment Hiroshi Ichikawa 2017/03/22 04:52:53 Done. Show quoted text On 2017/03/21 16:12:35, michaeldo wrote: > please re-wrap this comment Done.
	12 // WKUserScriptInjectionTimeAtDocumentStart).

	13 __attribute__((visibility("default")))
	michaeldo 2017/03/21 16:12:35 I think we shuold remove the visibility attribute I think we shuold remove the visibility attribute for now. It is missing from most of the other classes, and if we want to add them to all the classes, we should do that in a separate CL. If you want to add it here since this is a new header, please add to cwv_user_content_controller.h as well. Hiroshi Ichikawa 2017/03/22 04:52:53 Sure. Reverted. I added this here because my test Show quoted text On 2017/03/21 16:12:35, michaeldo wrote: > I think we shuold remove the visibility attribute for now. It is missing from > most of the other classes, and if we want to add them to all the classes, we > should do that in a separate CL. If you want to add it here since this is a new > header, please add to cwv_user_content_controller.h as well. Sure. Reverted. I added this here because my test code using this this feature didn't work without this attribute. michaeldo 2017/03/22 23:03:33 Understandable, thank you for creating the separat Show quoted text On 2017/03/22 04:52:53, Hiroshi Ichikawa wrote: > On 2017/03/21 16:12:35, michaeldo wrote: > > I think we shuold remove the visibility attribute for now. It is missing from > > most of the other classes, and if we want to add them to all the classes, we > > should do that in a separate CL. If you want to add it here since this is a > new > > header, please add to cwv_user_content_controller.h as well. > > Sure. Reverted. I added this here because my test code using this this feature > didn't work without this attribute. Understandable, thank you for creating the separate CL.
	14 @interface CWVUserScript : NSObject

	15

	16 // JavaScript source code.

	17 @property(copy, readonly) NSString* source;
	michaeldo 2017/03/21 16:12:35 Please add nullability annotations to this newly c Please add nullability annotations to this newly created header. Eugene But (OOO till 7-30) 2017/03/21 16:47:55 nonatomic? nonatomic? Hiroshi Ichikawa 2017/03/22 04:52:53 Done. Show quoted text On 2017/03/21 16:47:55, Eugene But wrote: > nonatomic? Done. Hiroshi Ichikawa 2017/03/22 04:52:53 Done. Show quoted text On 2017/03/21 16:12:35, michaeldo wrote: > Please add nullability annotations to this newly created header. Done.
	18

	19 - (instancetype)init NS_UNAVAILABLE;

	20

	21 - (instancetype)initWithSource:(NSString*)source;
	Eugene But (OOO till 7-30) 2017/03/21 16:47:55 Do you want to add nonnull to \|source\|? Do you want to add nonnull to \|source\|? Hiroshi Ichikawa 2017/03/22 04:52:53 Done. Show quoted text On 2017/03/21 16:47:55, Eugene But wrote: > Do you want to add nonnull to \|source\|? Done.
	22

	23 @end

	24

	25 #endif // IOS_WEB_VIEW_PUBLIC_CWV_USER_SCRIPT_H_

OLD	NEW