ios/web_view/internal/cwv_user_content_controller_internal.h - Issue 2764773002: Add CWVUserContentController which enables injecting JavaScripts.

Side by Side Diff: ios/web_view/internal/cwv_user_content_controller_internal.h

Issue 2764773002: Add CWVUserContentController which enables injecting JavaScripts. (Closed)

Patch Set: Add license. Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

« ios/web_view/internal/cwv_user_content_controller.mm ('K') | « ios/web_view/internal/cwv_user_content_controller.mm ('k') | ios/web_view/internal/cwv_user_script.mm » ('j') | ios/web_view/internal/cwv_user_script.mm » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 // Copyright 2017 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.
	michaeldo 2017/03/21 16:12:34 please add empty line after license, before header please add empty line after license, before header guard Hiroshi Ichikawa 2017/03/22 04:52:52 Done. Show quoted text On 2017/03/21 16:12:34, michaeldo wrote: > please add empty line after license, before header guard Done.
	4 #ifndef IOS_WEB_VIEW_PUBLIC_CWV_USER_CONTENT_CONTROLLER_INTERNAL_H_
	michaeldo 2017/03/21 16:12:34 s/PUBLIC/INTERNAL IOS_WEB_VIEW_INTERNAL_CWV_USER_ s/PUBLIC/INTERNAL IOS_WEB_VIEW_INTERNAL_CWV_USER_CONTENT_CONTROLLER_INTERNAL_H_ Hiroshi Ichikawa 2017/03/22 04:52:52 Oops. Done. Show quoted text On 2017/03/21 16:12:34, michaeldo wrote: > s/PUBLIC/INTERNAL > > IOS_WEB_VIEW_INTERNAL_CWV_USER_CONTENT_CONTROLLER_INTERNAL_H_ Oops. Done.
	5 #define IOS_WEB_VIEW_PUBLIC_CWV_USER_CONTENT_CONTROLLER_INTERNAL_H_

	6

	7 #import "ios/web_view/public/cwv_user_content_controller.h"

	8

	9 @class CWVWebViewConfiguration;

	10

	11 @interface CWVUserContentController ()

	12

	13 - (instancetype)initWithConfiguration:

	14 (__weak CWVWebViewConfiguration*)configuration;
	Eugene But (OOO till 7-30) 2017/03/21 16:47:55 Do you want to specify that \|configuration\| is non Do you want to specify that \|configuration\| is nonnull? Hiroshi Ichikawa 2017/03/22 04:52:52 Done. Added nonnull/nullable for other pointers in Show quoted text On 2017/03/21 16:47:55, Eugene But wrote: > Do you want to specify that \|configuration\| is nonnull? Done. Added nonnull/nullable for other pointers in this class too. michaeldo 2017/03/22 23:03:32 Thanks for adding these, based on other classes, l Show quoted text On 2017/03/22 04:52:52, Hiroshi Ichikawa wrote: > On 2017/03/21 16:47:55, Eugene But wrote: > > Do you want to specify that \|configuration\| is nonnull? > > Done. Added nonnull/nullable for other pointers in this class too. Thanks for adding these, based on other classes, like UIView's header, this initializer should return "nonnull instancetype". I believe nullable is usually only used for initializers that could commonly return nil, like initWithCoder methods. Even though initializers have the "if (self)" check within their implementation, I believe nonnull is the correct annotation for the return value. Hiroshi Ichikawa 2017/03/23 02:48:05 Good to know, thanks. Done. Show quoted text On 2017/03/22 23:03:32, michaeldo wrote: > On 2017/03/22 04:52:52, Hiroshi Ichikawa wrote: > > On 2017/03/21 16:47:55, Eugene But wrote: > > > Do you want to specify that \|configuration\| is nonnull? > > > > Done. Added nonnull/nullable for other pointers in this class too. > > Thanks for adding these, based on other classes, like UIView's header, this > initializer should return "nonnull instancetype". I believe nullable is usually > only used for initializers that could commonly return nil, like initWithCoder > methods. Even though initializers have the "if (self)" check within their > implementation, I believe nonnull is the correct annotation for the return > value. Good to know, thanks. Done.
	15

	16 @end

	17

	18 #endif // IOS_WEB_VIEW_PUBLIC_CWV_USER_CONTENT_CONTROLLER_INTERNAL_H_

OLD	NEW