Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(269)

Issue 2764753008: Revert "VM: Handle null-comparisons in the flow graph type propagation" (Closed)

Created:
3 years, 9 months ago by kustermann
Modified:
3 years, 9 months ago
Reviewers:
Florian Schneider
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Revert "VM: Handle null-comparisons in the flow graph type propagation" This reverts commit 2cd2ffa9497f08c1c5347511e5c6771e60c0721c. Reason for revert: This seems to have caused crashes on various windows builders on service tests. The crashes seem to be slightly flaky. Committed: https://github.com/dart-lang/sdk/commit/30a942f7287e67d4bcf43f2959428033612b1a70

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -19 lines) Patch
M runtime/vm/flow_graph_type_propagator.cc View 2 chunks +2 lines, -18 lines 0 comments Download
M runtime/vm/intermediate_language.h View 1 chunk +5 lines, -1 line 0 comments Download

Messages

Total messages: 4 (2 generated)
kustermann
@Florian: These crashes happened a lot on vm-win-debug-ia32-be and vm-win-debug-ia32-russian-be. Example failures: https://uberchromegw.corp.google.com/i/client.dart/builders/vm-win-debug-ia32-be/builds/3612/steps/checked%20vm%20tests/logs/stdio It hits ...
3 years, 9 months ago (2017-03-22 13:06:33 UTC) #2
kustermann
3 years, 9 months ago (2017-03-22 13:07:05 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
30a942f7287e67d4bcf43f2959428033612b1a70 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698