Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(508)

Unified Diff: third_party/WebKit/Source/core/layout/ng/ng_fragment_builder.cc

Issue 2764753007: [LayoutNG] Add NGLineBoxFragment (Closed)
Patch Set: Rebase again as other CLs landed faster Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/layout/ng/ng_fragment_builder.cc
diff --git a/third_party/WebKit/Source/core/layout/ng/ng_fragment_builder.cc b/third_party/WebKit/Source/core/layout/ng/ng_fragment_builder.cc
index 7348e7eafef395d96fd3c677172ae6fa200444a3..51d4b5fae1581d13d8b4c4b3589d20f5b24b278c 100644
--- a/third_party/WebKit/Source/core/layout/ng/ng_fragment_builder.cc
+++ b/third_party/WebKit/Source/core/layout/ng/ng_fragment_builder.cc
@@ -161,7 +161,6 @@ NGFragmentBuilder& NGFragmentBuilder::AddOutOfFlowDescendant(
}
RefPtr<NGLayoutResult> NGFragmentBuilder::ToBoxFragment() {
- // TODO(layout-ng): Support text fragments
DCHECK_EQ(type_, NGPhysicalFragment::kFragmentBox);
DCHECK_EQ(offsets_.size(), children_.size());
@@ -198,18 +197,4 @@ RefPtr<NGLayoutResult> NGFragmentBuilder::ToBoxFragment() {
out_of_flow_positions_, unpositioned_floats_));
}
-RefPtr<NGPhysicalTextFragment> NGFragmentBuilder::ToTextFragment(
- unsigned index,
- unsigned start_offset,
- unsigned end_offset) {
- DCHECK_EQ(type_, NGPhysicalFragment::kFragmentText);
- DCHECK(children_.isEmpty());
- DCHECK(offsets_.isEmpty());
-
- return adoptRef(new NGPhysicalTextFragment(
- node_->GetLayoutObject(), toNGInlineNode(node_), index, start_offset,
- end_offset, size_.ConvertToPhysical(writing_mode_),
- overflow_.ConvertToPhysical(writing_mode_)));
-}
-
} // namespace blink

Powered by Google App Engine
This is Rietveld 408576698