Add DocumentMarker::createGrammarMarker() and createSpellingMarker()

third_party/WebKit/Source/core/editing/markers/DocumentMarker.cpp

 /*
  * Copyright (C) 2011 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 114 matching lines @@
 inline TextCompositionMarkerDetails* toTextCompositionMarkerDetails(
     DocumentMarkerDetails* details) {
   if (details && details->isComposition())
     return static_cast<TextCompositionMarkerDetails*>(details);
   return nullptr;
 }
 
 DocumentMarker::DocumentMarker(MarkerType type,
                                unsigned startOffset,
                                unsigned endOffset,
-                               const String& description)
-    : m_type(type),
-      m_startOffset(startOffset),
-      m_endOffset(endOffset),
-      m_details(description.isEmpty()
-                    ? nullptr
-                    : DocumentMarkerDescription::create(description)) {}
-
-DocumentMarker::DocumentMarker(MarkerType type,
-                               unsigned startOffset,
-                               unsigned endOffset,
                                DocumentMarkerDetails* details)
     : m_type(type),
       m_startOffset(startOffset),
       m_endOffset(endOffset),
       m_details(details) {}
 
 DocumentMarker* DocumentMarker::createCompositionMarker(unsigned startOffset,
                                                         unsigned endOffset,
                                                         Color underlineColor,
                                                         bool thick,
                                                         Color backgroundColor) {
   return new DocumentMarker(Composition, startOffset, endOffset,
                             TextCompositionMarkerDetails::create(
                                 underlineColor, thick, backgroundColor));
 }
 
+DocumentMarker* DocumentMarker::createGrammarMarker(unsigned startOffset,
+                                                    unsigned endOffset,
+                                                    const String& description) {
+  return new DocumentMarker(Grammar, startOffset, endOffset,

[yosin_UTC9, 2017/03/23 04:01:27]

Could you add TODO that we should have DCHECK_LT(startOffset, endOffset)?

[rlanday, 2017/03/23 04:38:21]

Just to clarify, why do you want me to add a TODO instead of just adding the
DCHECK?

+                            DocumentMarkerDescription::create(description));
+}
+
+DocumentMarker* DocumentMarker::createSpellingMarker(
+    unsigned startOffset,
+    unsigned endOffset,
+    const String& description) {
+  return new DocumentMarker(Spelling, startOffset, endOffset,

[yosin_UTC9, 2017/03/23 04:01:27]

Could you add TODO that we should have DCHECK_LT(startOffset, endOffset)?

+                            DocumentMarkerDescription::create(description));
+}
+
 DocumentMarker* DocumentMarker::createTextMatchMarker(unsigned startOffset,
                                                       unsigned endOffset,
                                                       bool activeMatch) {
   return new DocumentMarker(TextMatch, startOffset, endOffset,
                             DocumentMarkerTextMatch::create(activeMatch));
 }
 
 DocumentMarker::DocumentMarker(const DocumentMarker& marker)
     : m_type(marker.type()),
       m_startOffset(marker.startOffset()),
@@ skipping 86 matching lines @@
           toTextCompositionMarkerDetails(m_details.get()))
     return details->backgroundColor();
   return Color::transparent;
 }
 
 DEFINE_TRACE(DocumentMarker) {
   visitor->trace(m_details);
 }
 
 }  // namespace blink