Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Side by Side Diff: base/task_scheduler/task_scheduler.cc

Issue 2764603002: Add TaskScheduler::InitParams and accept it in TaskSchedulerImpl constructor. (Closed)
Patch Set: self-review Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/task_scheduler/task_scheduler.h" 5 #include "base/task_scheduler/task_scheduler.h"
6 6
7 #include <algorithm> 7 #include <algorithm>
8 8
9 #include "base/bind.h" 9 #include "base/bind.h"
10 #include "base/logging.h" 10 #include "base/logging.h"
11 #include "base/sys_info.h" 11 #include "base/sys_info.h"
12 #include "base/task_scheduler/scheduler_worker_pool_params.h" 12 #include "base/task_scheduler/scheduler_worker_pool_params.h"
13 #include "base/task_scheduler/task_scheduler_impl.h" 13 #include "base/task_scheduler/task_scheduler_impl.h"
14 #include "base/threading/platform_thread.h" 14 #include "base/threading/platform_thread.h"
15 #include "base/time/time.h" 15 #include "base/time/time.h"
16 16
17 namespace base { 17 namespace base {
18 18
19 namespace { 19 namespace {
20 20
21 // |g_task_scheduler| is intentionally leaked on shutdown. 21 // |g_task_scheduler| is intentionally leaked on shutdown.
22 TaskScheduler* g_task_scheduler = nullptr; 22 TaskScheduler* g_task_scheduler = nullptr;
23 23
24 SchedulerWorkerPoolParams AugmentWorkerPoolParamsWithNameAndPriority(
robliao 2017/03/23 18:00:52 This can be removed, right?
fdoray 2017/03/24 14:00:38 Done.
25 const std::string& name,
26 ThreadPriority priority_hint,
27 const SchedulerWorkerPoolParams params) {
28 return SchedulerWorkerPoolParams(
29 name, priority_hint, params.standby_thread_policy(), params.max_threads(),
30 params.suggested_reclaim_time(), params.backward_compatibility());
31 }
32
24 } // namespace 33 } // namespace
25 34
35 TaskScheduler::InitParams::InitParams(
36 const SchedulerWorkerPoolParams& background_worker_pool_params_in,
37 const SchedulerWorkerPoolParams& background_blocking_worker_pool_params_in,
38 const SchedulerWorkerPoolParams& foreground_worker_pool_params_in,
39 const SchedulerWorkerPoolParams& foreground_blocking_worker_pool_params_in)
40 : background_worker_pool_params(background_worker_pool_params_in),
41 background_blocking_worker_pool_params(
42 background_blocking_worker_pool_params_in),
43 foreground_worker_pool_params(foreground_worker_pool_params_in),
44 foreground_blocking_worker_pool_params(
45 foreground_blocking_worker_pool_params_in) {}
46
26 #if !defined(OS_NACL) 47 #if !defined(OS_NACL)
27 // static 48 // static
28 void TaskScheduler::CreateAndSetSimpleTaskScheduler(const std::string& name) { 49 void TaskScheduler::CreateAndSetSimpleTaskScheduler(const std::string& name) {
29 constexpr int kMinNumThreads = 1; 50 constexpr int kMinNumThreads = 1;
30 std::vector<SchedulerWorkerPoolParams> worker_pool_params_vector; 51 std::vector<SchedulerWorkerPoolParams> worker_pool_params_vector;
31 worker_pool_params_vector.emplace_back( 52 worker_pool_params_vector.emplace_back(
32 name, ThreadPriority::NORMAL, 53 name, ThreadPriority::NORMAL,
33 SchedulerWorkerPoolParams::StandbyThreadPolicy::LAZY, 54 SchedulerWorkerPoolParams::StandbyThreadPolicy::LAZY,
34 std::max(kMinNumThreads, base::SysInfo::NumberOfProcessors()), 55 std::max(kMinNumThreads, SysInfo::NumberOfProcessors()),
35 TimeDelta::FromSeconds(30)); 56 TimeDelta::FromSeconds(30));
36 CreateAndSetDefaultTaskScheduler( 57 CreateAndSetDefaultTaskScheduler(
37 worker_pool_params_vector, 58 worker_pool_params_vector,
38 Bind([](const TaskTraits&) -> size_t { return 0; })); 59 Bind([](const TaskTraits&) -> size_t { return 0; }));
39 } 60 }
40 #endif // !defined(OS_NACL) 61 #endif // !defined(OS_NACL)
41 62
42 // static 63 // static
43 void TaskScheduler::CreateAndSetDefaultTaskScheduler( 64 void TaskScheduler::CreateAndSetDefaultTaskScheduler(
44 const std::vector<SchedulerWorkerPoolParams>& worker_pool_params_vector, 65 const std::vector<SchedulerWorkerPoolParams>& worker_pool_params_vector,
45 const WorkerPoolIndexForTraitsCallback& 66 const WorkerPoolIndexForTraitsCallback&
46 worker_pool_index_for_traits_callback) { 67 worker_pool_index_for_traits_callback) {
47 SetInstance(internal::TaskSchedulerImpl::Create( 68 SetInstance(internal::TaskSchedulerImpl::Create(
48 worker_pool_params_vector, worker_pool_index_for_traits_callback)); 69 worker_pool_params_vector, worker_pool_index_for_traits_callback));
49 } 70 }
50 71
72 void TaskScheduler::CreateAndSetDefaultTaskScheduler(
73 const std::string& name,
74 const InitParams& init_params) {
75 SetInstance(internal::TaskSchedulerImpl::Create(name, init_params));
76 }
77
51 // static 78 // static
52 void TaskScheduler::SetInstance(std::unique_ptr<TaskScheduler> task_scheduler) { 79 void TaskScheduler::SetInstance(std::unique_ptr<TaskScheduler> task_scheduler) {
53 delete g_task_scheduler; 80 delete g_task_scheduler;
54 g_task_scheduler = task_scheduler.release(); 81 g_task_scheduler = task_scheduler.release();
55 } 82 }
56 83
57 // static 84 // static
58 TaskScheduler* TaskScheduler::GetInstance() { 85 TaskScheduler* TaskScheduler::GetInstance() {
59 return g_task_scheduler; 86 return g_task_scheduler;
60 } 87 }
61 88
62 } // namespace base 89 } // namespace base
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698