[wasm] Fix wasm interpreter entry for 32 bit big endian systems

src/compiler/wasm-compiler.cc

 // Copyright 2015 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/compiler/wasm-compiler.h"
 
 #include <memory>
 
 #include "src/assembler-inl.h"
 #include "src/base/platform/elapsed-timer.h"
@@ skipping 2831 matching lines @@
   } else if (Int64Lowering::IsI64AsTwoParameters(jsgraph()->machine(),
                                                  sig->GetReturn())) {
     MachineType load_rep = wasm::WasmOpcodes::MachineTypeFor(wasm::kWasmI32);
     Node* lower =
         graph()->NewNode(jsgraph()->machine()->Load(load_rep), arg_buffer,
                          Int32Constant(0), *effect_, *control_);
     Node* upper =
         graph()->NewNode(jsgraph()->machine()->Load(load_rep), arg_buffer,
                          Int32Constant(sizeof(int32_t)), lower, *control_);
     *effect_ = upper;
+#if defined(V8_TARGET_LITTLE_ENDIAN)

[Clemens Hammacher, 2017/03/21 08:36:10]

Instead of introducing another "#if defined(...)", can you please use the
kInt64LowerHalfMemoryOffset and kInt64UpperHalfMemoryOffset constants to load
the lower and upper half, similar to the store nodes for the parameters a few
lines above?

[rayb, 2017/03/22 17:21:47]

Done.

     Return(lower, upper);
+#elif defined(V8_TARGET_BIG_ENDIAN)
+    Return(upper, lower);
+#endif
   } else {
     MachineType load_rep = wasm::WasmOpcodes::MachineTypeFor(sig->GetReturn());
     Node* val =
         graph()->NewNode(jsgraph()->machine()->Load(load_rep), arg_buffer,
                          Int32Constant(0), *effect_, *control_);
     Return(val);
   }
 }
 
 Node* WasmGraphBuilder::MemBuffer(uint32_t offset) {
@@ skipping 1194 matching lines @@
     wasm::ErrorThrower* thrower, Isolate* isolate,
     wasm::ModuleBytesEnv* module_env, const wasm::WasmFunction* function) {
   WasmCompilationUnit unit(isolate, module_env, function);
   unit.ExecuteCompilation();
   return unit.FinishCompilation(thrower);
 }
 
 }  // namespace compiler
 }  // namespace internal
 }  // namespace v8