Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(590)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: components/reading_list/ios/reading_list_entry_unittest.cc

Issue 2764533002: Reading List iOS: Use external clock in ReadingListEntry. (Closed)
Patch Set: fix microseconds Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« components/reading_list/ios/reading_list_entry.cc ('K') | « components/reading_list/ios/reading_list_entry.cc ('k') | components/reading_list/ios/reading_list_model.h » ('j') | components/reading_list/ios/reading_list_model_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/reading_list/ios/reading_list_entry_unittest.cc
diff --git a/components/reading_list/ios/reading_list_entry_unittest.cc b/components/reading_list/ios/reading_list_entry_unittest.cc
index a4e38b534d5820f15d63a056b7dbacb8bf58ea6f..3a9cbcfc7ca54b0c183670fdaa4828bfdebd4cd6 100644
--- a/components/reading_list/ios/reading_list_entry_unittest.cc
+++ b/components/reading_list/ios/reading_list_entry_unittest.cc
@@ -5,7 +5,6 @@
#include "components/reading_list/ios/reading_list_entry.h"
#include "base/memory/ptr_util.h"
-#include "base/test/ios/wait_util.h"
#include "base/test/simple_test_tick_clock.h"
#include "components/reading_list/ios/proto/reading_list.pb.h"
#include "components/sync/protocol/reading_list_specifics.pb.h"
@@ -21,57 +20,68 @@ const int kFifthBackoff = 120;
} // namespace
TEST(ReadingListEntry, CompareIgnoreTitle) {
- const ReadingListEntry e1(GURL("http://example.com"), "bar");
- const ReadingListEntry e2(GURL("http://example.com"), "foo");
+ const ReadingListEntry e1(GURL("http://example.com"), "bar",
+ base::Time::FromTimeT(10));
+ const ReadingListEntry e2(GURL("http://example.com"), "foo",
+ base::Time::FromTimeT(20));
EXPECT_EQ(e1, e2);
}
-TEST(ReadingListEntry, CompareFailureIgnoreTitle) {
- const ReadingListEntry e1(GURL("http://example.com"), "bar");
- const ReadingListEntry e2(GURL("http://example.org"), "bar");
+TEST(ReadingListEntry, CompareFailureIgnoreTitleAndCreationTime) {
+ const ReadingListEntry e1(GURL("http://example.com"), "bar",
+ base::Time::FromTimeT(10));
+ const ReadingListEntry e2(GURL("http://example.org"), "bar",
+ base::Time::FromTimeT(10));
EXPECT_FALSE(e1 == e2);
}
TEST(ReadingListEntry, MovesAreEquals) {
- ReadingListEntry e1(GURL("http://example.com"), "bar");
- ReadingListEntry e2(GURL("http://example.com"), "bar");
+ ReadingListEntry e1(GURL("http://example.com"), "bar",
+ base::Time::FromTimeT(10));
+ ReadingListEntry e2(GURL("http://example.com"), "bar",
+ base::Time::FromTimeT(10));
ASSERT_EQ(e1, e2);
ASSERT_EQ(e1.Title(), e2.Title());
+ ASSERT_EQ(e1.CreationTime(), e2.CreationTime());
ReadingListEntry e3(std::move(e1));
EXPECT_EQ(e3, e2);
EXPECT_EQ(e3.Title(), e2.Title());
+ ASSERT_EQ(e3.CreationTime(), e2.CreationTime());
}
TEST(ReadingListEntry, ReadState) {
- ReadingListEntry e(GURL("http://example.com"), "bar");
+ ReadingListEntry e(GURL("http://example.com"), "bar",
+ base::Time::FromTimeT(10));
EXPECT_FALSE(e.HasBeenSeen());
EXPECT_FALSE(e.IsRead());
- e.SetRead(false);
+ e.SetRead(false, base::Time::FromTimeT(20));
gambard 2017/03/21 13:08:06 Test update time
Olivier 2017/03/21 14:01:09 Done.
Olivier 2017/03/21 14:01:09 Done.
EXPECT_TRUE(e.HasBeenSeen());
EXPECT_FALSE(e.IsRead());
- e.SetRead(true);
+ e.SetRead(true, base::Time::FromTimeT(30));
gambard 2017/03/21 13:08:06 Test update time
Olivier 2017/03/21 14:01:09 Done.
EXPECT_TRUE(e.HasBeenSeen());
EXPECT_TRUE(e.IsRead());
}
TEST(ReadingListEntry, UpdateTitle) {
- ReadingListEntry e(GURL("http://example.com"), "bar");
+ ReadingListEntry e(GURL("http://example.com"), "bar",
+ base::Time::FromTimeT(10));
ASSERT_EQ("bar", e.Title());
- ASSERT_EQ(e.CreationTime(), e.UpdateTitleTime());
+ // Getters are in microseconds.
gambard 2017/03/21 13:08:06 What about creating a kMicrosecondInOneSecond (or
Olivier 2017/03/21 14:01:09 Done.
+ ASSERT_EQ(e.CreationTime(), 10000000);
+ ASSERT_EQ(e.UpdateTitleTime(), 10000000);
- base::test::ios::SpinRunLoopWithMinDelay(
- base::TimeDelta::FromMilliseconds(5));
- e.SetTitle("foo");
- EXPECT_GT(e.UpdateTitleTime(), e.CreationTime());
+ e.SetTitle("foo", base::Time::FromTimeT(15));
+ EXPECT_EQ(e.UpdateTitleTime(), 15000000);
EXPECT_EQ("foo", e.Title());
}
TEST(ReadingListEntry, DistilledInfo) {
- ReadingListEntry e(GURL("http://example.com"), "bar");
+ ReadingListEntry e(GURL("http://example.com"), "bar",
+ base::Time::FromTimeT(10));
EXPECT_TRUE(e.DistilledPath().empty());
@@ -79,15 +89,17 @@ TEST(ReadingListEntry, DistilledInfo) {
const GURL distilled_url("http://example.com/distilled");
int64_t size = 50;
int64_t time = 100;
- e.SetDistilledInfo(distilled_path, distilled_url, size, time);
+ e.SetDistilledInfo(distilled_path, distilled_url, size,
+ base::Time::FromTimeT(time));
EXPECT_EQ(distilled_path, e.DistilledPath());
EXPECT_EQ(distilled_url, e.DistilledURL());
EXPECT_EQ(size, e.DistillationSize());
- EXPECT_EQ(e.DistillationTime(), time);
+ EXPECT_EQ(e.DistillationTime(), time * 1000000);
}
TEST(ReadingListEntry, DistilledState) {
- ReadingListEntry e(GURL("http://example.com"), "bar");
+ ReadingListEntry e(GURL("http://example.com"), "bar",
+ base::Time::FromTimeT(10));
EXPECT_EQ(ReadingListEntry::WAITING, e.DistilledState());
@@ -96,7 +108,8 @@ TEST(ReadingListEntry, DistilledState) {
const base::FilePath distilled_path("distilled/page.html");
const GURL distilled_url("http://example.com/distilled");
- e.SetDistilledInfo(distilled_path, distilled_url, 50, 100);
+ e.SetDistilledInfo(distilled_path, distilled_url, 50,
+ base::Time::FromTimeT(100));
EXPECT_EQ(ReadingListEntry::PROCESSED, e.DistilledState());
}
@@ -108,7 +121,8 @@ TEST(ReadingListEntry, TimeUntilNextTry) {
base::MakeUnique<net::BackoffEntry>(&ReadingListEntry::kBackoffPolicy,
&clock);
- ReadingListEntry e(GURL("http://example.com"), "bar", std::move(backoff));
+ ReadingListEntry e(GURL("http://example.com"), "bar",
+ base::Time::FromTimeT(10), std::move(backoff));
double fuzzing = ReadingListEntry::kBackoffPolicy.jitter_factor;
@@ -159,7 +173,8 @@ TEST(ReadingListEntry, TimeUntilNextTryInThePast) {
std::unique_ptr<net::BackoffEntry> backoff =
base::MakeUnique<net::BackoffEntry>(&ReadingListEntry::kBackoffPolicy,
&clock);
- ReadingListEntry e(GURL("http://example.com"), "bar", std::move(backoff));
+ ReadingListEntry e(GURL("http://example.com"), "bar",
+ base::Time::FromTimeT(10), std::move(backoff));
double fuzzing = ReadingListEntry::kBackoffPolicy.jitter_factor;
e.SetDistilledState(ReadingListEntry::ERROR);
@@ -180,7 +195,8 @@ TEST(ReadingListEntry, ResetTimeUntilNextTry) {
std::unique_ptr<net::BackoffEntry> backoff =
base::MakeUnique<net::BackoffEntry>(&ReadingListEntry::kBackoffPolicy,
&clock);
- ReadingListEntry e(GURL("http://example.com"), "bar", std::move(backoff));
+ ReadingListEntry e(GURL("http://example.com"), "bar",
+ base::Time::FromTimeT(10), std::move(backoff));
double fuzzing = ReadingListEntry::kBackoffPolicy.jitter_factor;
e.SetDistilledState(ReadingListEntry::ERROR);
@@ -190,7 +206,8 @@ TEST(ReadingListEntry, ResetTimeUntilNextTry) {
// Action.
const base::FilePath distilled_path("distilled/page.html");
const GURL distilled_url("http://example.com/distilled");
- e.SetDistilledInfo(distilled_path, distilled_url, 50, 100);
+ e.SetDistilledInfo(distilled_path, distilled_url, 50,
+ base::Time::FromTimeT(100));
// Test.
EXPECT_EQ(0, e.TimeUntilNextTry().InSeconds());
@@ -202,7 +219,8 @@ TEST(ReadingListEntry, ResetTimeUntilNextTry) {
// Tests that the failed download counter is incremented when the state change
// from non-error to error.
TEST(ReadingListEntry, FailedDownloadCounter) {
- ReadingListEntry e(GURL("http://example.com"), "bar");
+ ReadingListEntry e(GURL("http://example.com"), "bar",
+ base::Time::FromTimeT(10));
ASSERT_EQ(0, e.FailedDownloadCounter());
@@ -223,7 +241,8 @@ TEST(ReadingListEntry, FailedDownloadCounter) {
// Tests that the reading list entry is correctly encoded to
// sync_pb::ReadingListSpecifics.
TEST(ReadingListEntry, AsReadingListSpecifics) {
- ReadingListEntry entry(GURL("http://example.com/"), "bar");
+ ReadingListEntry entry(GURL("http://example.com"), "bar",
+ base::Time::FromTimeT(10));
int64_t creation_time_us = entry.UpdateTime();
std::unique_ptr<sync_pb::ReadingListSpecifics> pb_entry(
@@ -235,8 +254,10 @@ TEST(ReadingListEntry, AsReadingListSpecifics) {
EXPECT_EQ(pb_entry->update_time_us(), entry.UpdateTime());
EXPECT_EQ(pb_entry->status(), sync_pb::ReadingListSpecifics::UNSEEN);
- entry.SetRead(true);
- EXPECT_NE(entry.UpdateTime(), creation_time_us);
+ entry.SetRead(true, base::Time::FromTimeT(15));
+ // Getters are in microseconds.
+ EXPECT_EQ(entry.CreationTime(), 10000000);
+ EXPECT_EQ(entry.UpdateTime(), 15000000);
std::unique_ptr<sync_pb::ReadingListSpecifics> updated_pb_entry(
entry.AsReadingListSpecifics());
EXPECT_EQ(updated_pb_entry->creation_time_us(), creation_time_us);
@@ -254,10 +275,12 @@ TEST(ReadingListEntry, FromReadingListSpecifics) {
pb_entry->set_title("title");
pb_entry->set_creation_time_us(1);
pb_entry->set_update_time_us(2);
+ pb_entry->set_update_title_time_us(3);
gambard 2017/03/21 13:08:07 You are setting it but not checking it. Same for t
Olivier 2017/03/21 14:01:09 Done.
pb_entry->set_status(sync_pb::ReadingListSpecifics::UNREAD);
std::unique_ptr<ReadingListEntry> entry(
- ReadingListEntry::FromReadingListSpecifics(*pb_entry));
+ ReadingListEntry::FromReadingListSpecifics(*pb_entry,
+ base::Time::FromTimeT(10)));
gambard 2017/03/21 13:08:06 You can test the deserialization value for the bac
Olivier 2017/03/21 14:01:09 There is no serialized backoff in ReadingListSpeci
gambard 2017/03/21 15:36:53 Acknowledged.
EXPECT_EQ(entry->URL().spec(), "http://example.com/");
EXPECT_EQ(entry->Title(), "title");
EXPECT_EQ(entry->UpdateTime(), 2);
@@ -267,11 +290,12 @@ TEST(ReadingListEntry, FromReadingListSpecifics) {
// Tests that the reading list entry is correctly encoded to
// reading_list::ReadingListLocal.
TEST(ReadingListEntry, AsReadingListLocal) {
- ReadingListEntry entry(GURL("http://example.com/"), "bar");
+ ReadingListEntry entry(GURL("http://example.com/"), "bar",
+ base::Time::FromTimeT(10));
int64_t creation_time_us = entry.UpdateTime();
gambard 2017/03/21 13:08:06 Maybe you should set a different update time and t
Olivier 2017/03/21 14:01:10 Done.
std::unique_ptr<reading_list::ReadingListLocal> pb_entry(
- entry.AsReadingListLocal());
+ entry.AsReadingListLocal(base::Time::Now()));
gambard 2017/03/21 13:08:06 Why base::Time::Now()?
Olivier 2017/03/21 14:01:10 Done.
EXPECT_EQ(pb_entry->entry_id(), "http://example.com/");
EXPECT_EQ(pb_entry->url(), "http://example.com/");
EXPECT_EQ(pb_entry->title(), "bar");
@@ -286,7 +310,7 @@ TEST(ReadingListEntry, AsReadingListLocal) {
entry.SetDistilledState(ReadingListEntry::WILL_RETRY);
std::unique_ptr<reading_list::ReadingListLocal> will_retry_pb_entry(
- entry.AsReadingListLocal());
+ entry.AsReadingListLocal(base::Time::Now()));
gambard 2017/03/21 13:08:06 Same
Olivier 2017/03/21 14:01:09 Done.
EXPECT_EQ(will_retry_pb_entry->distillation_state(),
reading_list::ReadingListLocal::WILL_RETRY);
EXPECT_EQ(will_retry_pb_entry->failed_download_counter(), 1);
@@ -294,13 +318,14 @@ TEST(ReadingListEntry, AsReadingListLocal) {
const base::FilePath distilled_path("distilled/page.html");
const GURL distilled_url("http://example.com/distilled");
int64_t size = 50;
- entry.SetDistilledInfo(distilled_path, distilled_url, size, 100);
+ entry.SetDistilledInfo(distilled_path, distilled_url, size,
+ base::Time::FromTimeT(100));
- entry.SetRead(true);
- entry.MarkEntryUpdated();
+ entry.SetRead(true, base::Time::FromTimeT(20));
+ entry.MarkEntryUpdated(base::Time::FromTimeT(30));
EXPECT_NE(entry.UpdateTime(), creation_time_us);
std::unique_ptr<reading_list::ReadingListLocal> distilled_pb_entry(
- entry.AsReadingListLocal());
+ entry.AsReadingListLocal(base::Time::Now()));
gambard 2017/03/21 13:08:06 Same
Olivier 2017/03/21 14:01:10 Done.
EXPECT_EQ(distilled_pb_entry->creation_time_us(), creation_time_us);
EXPECT_EQ(distilled_pb_entry->update_time_us(), entry.UpdateTime());
EXPECT_NE(distilled_pb_entry->backoff(), "");
@@ -317,11 +342,12 @@ TEST(ReadingListEntry, AsReadingListLocal) {
// Tests that the reading list entry is correctly parsed from
// sync_pb::ReadingListLocal.
TEST(ReadingListEntry, FromReadingListLocal) {
- ReadingListEntry entry(GURL("http://example.com/"), "title");
+ ReadingListEntry entry(GURL("http://example.com/"), "title",
+ base::Time::FromTimeT(10));
entry.SetDistilledState(ReadingListEntry::ERROR);
std::unique_ptr<reading_list::ReadingListLocal> pb_entry(
- entry.AsReadingListLocal());
+ entry.AsReadingListLocal(base::Time::FromTimeT(10)));
int64_t now = 12345;
pb_entry->set_entry_id("http://example.com/");
@@ -336,7 +362,8 @@ TEST(ReadingListEntry, FromReadingListLocal) {
pb_entry->set_distillation_size(50);
std::unique_ptr<ReadingListEntry> waiting_entry(
- ReadingListEntry::FromReadingListLocal(*pb_entry));
+ ReadingListEntry::FromReadingListLocal(*pb_entry,
+ base::Time::FromTimeT(20)));
EXPECT_EQ(waiting_entry->URL().spec(), "http://example.com/");
EXPECT_EQ(waiting_entry->Title(), "title");
EXPECT_EQ(waiting_entry->UpdateTime(), 2);
@@ -354,11 +381,13 @@ TEST(ReadingListEntry, FromReadingListLocal) {
// Additional merging tests are done in
// ReadingListStoreTest.CompareEntriesForSync
TEST(ReadingListEntry, MergeWithEntry) {
- ReadingListEntry local_entry(GURL("http://example.com/"), "title");
+ ReadingListEntry local_entry(GURL("http://example.com/"), "title",
+ base::Time::FromTimeT(10));
local_entry.SetDistilledState(ReadingListEntry::ERROR);
int64_t local_update_time_us = local_entry.UpdateTime();
- ReadingListEntry sync_entry(GURL("http://example.com/"), "title2");
+ ReadingListEntry sync_entry(GURL("http://example.com/"), "title2",
+ base::Time::FromTimeT(20));
sync_entry.SetDistilledState(ReadingListEntry::ERROR);
int64_t sync_update_time_us = sync_entry.UpdateTime();
EXPECT_NE(local_update_time_us, sync_update_time_us);
« components/reading_list/ios/reading_list_entry.cc ('K') | « components/reading_list/ios/reading_list_entry.cc ('k') | components/reading_list/ios/reading_list_model.h » ('j') | components/reading_list/ios/reading_list_model_unittest.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698