ios/chrome/browser/ui/reading_list/reading_list_collection_view_controller_unittest.mm - Issue 2764533002: Reading List iOS: Use external clock in ReadingListEntry.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ios/chrome/browser/ui/reading_list/reading_list_collection_view_controller_unittest.mm

Issue 2764533002: Reading List iOS: Use external clock in ReadingListEntry. (Closed)

Patch Set: jitter Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « ios/chrome/browser/reading_list/reading_list_web_state_observer_unittest.mm ('k') | ios/chrome/browser/ui/reading_list/reading_list_coordinator_unittest.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: ios/chrome/browser/ui/reading_list/reading_list_collection_view_controller_unittest.mm

diff --git a/ios/chrome/browser/ui/reading_list/reading_list_collection_view_controller_unittest.mm b/ios/chrome/browser/ui/reading_list/reading_list_collection_view_controller_unittest.mm

index 487755f4b49a6e65b744de41d8bb45789a946859..47e643f42328eed41c95b224c6fb6f6cae93e129 100644

--- a/ios/chrome/browser/ui/reading_list/reading_list_collection_view_controller_unittest.mm

+++ b/ios/chrome/browser/ui/reading_list/reading_list_collection_view_controller_unittest.mm

@@ -12,6 +12,7 @@

#include "base/single_thread_task_runner.h"

#include "base/strings/sys_string_conversions.h"

#include "base/threading/thread_task_runner_handle.h"

+#include "base/time/default_clock.h"

#include "components/favicon/core/large_icon_service.h"

#include "components/favicon/core/test/mock_favicon_service.h"

#include "components/reading_list/ios/reading_list_model.h"

@@ -56,7 +57,8 @@ class ReadingListCollectionViewControllerTest : public testing::Test {

GetLargestRawFaviconForPageURL(_, _, _, _, _))

.WillRepeatedly(PostReply<5>(favicon_base::FaviconRawBitmapResult()));

- reading_list_model_.reset(new ReadingListModelImpl(nullptr, nullptr));

+ reading_list_model_.reset(new ReadingListModelImpl(

+ nullptr, nullptr, base::MakeUnique<base::DefaultClock>()));

large_icon_service_.reset(new favicon::LargeIconService(

&mock_favicon_service_, base::ThreadTaskRunnerHandle::Get()));

reading_list_view_controller_.reset(

@@ -190,7 +192,7 @@ TEST_F(ReadingListCollectionViewControllerTest,

reading_list::ADDED_VIA_CURRENT_APP);

int64_t size = 50;

reading_list_model_->SetEntryDistilledInfo(url, distilled_path, distilled_url,

- size, 100);

+ size, base::Time::FromTimeT(100));

// Load view.

[reading_list_view_controller_ view];

DCHECK([reading_list_view_controller_.get().collectionView