Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(239)

Unified Diff: tools/perf/benchmarks/v8.py

Issue 2764493002: Enable EQT metric for v8.infinite_scroll* benchmarks. (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/perf/benchmarks/v8.py
diff --git a/tools/perf/benchmarks/v8.py b/tools/perf/benchmarks/v8.py
index 45bf8db16e1b777c635c8f2e13e8336ace73b093..6a273c3e9f68c31e9e5ef7f12698d73597e071b9 100644
--- a/tools/perf/benchmarks/v8.py
+++ b/tools/perf/benchmarks/v8.py
@@ -99,19 +99,30 @@ class _InfiniteScrollBenchmark(perf_benchmark.PerfBenchmark):
v8_helper.AppendJSFlags(options, '--heap-growing-percent=10')
def CreateTimelineBasedMeasurementOptions(self):
- v8_categories = [
- 'blink.console', 'disabled-by-default-v8.gc',
- 'renderer.scheduler', 'v8', 'webkit.console']
- smoothness_categories = [
- 'webkit.console', 'blink.console', 'benchmark', 'trace_event_overhead']
- memory_categories = ['blink.console', 'disabled-by-default-memory-infra']
+ categories = [
+ # Disable all categories by default.
+ '-*',
+ # Memory categories.
+ 'disabled-by-default-memory-infra',
+ # EQT categories.
+ 'blink.user_timing',
+ 'loading',
+ 'navigation',
+ 'toplevel',
+ # V8 categories.
+ 'blink.console',
+ 'disabled-by-default-v8.gc',
+ 'renderer.scheduler',
+ 'v8',
+ 'webkit.console'
+ ]
category_filter = chrome_trace_category_filter.ChromeTraceCategoryFilter(
- ','.join(['-*'] + v8_categories +
- smoothness_categories + memory_categories))
+ ','.join(categories))
options = timeline_based_measurement.Options(category_filter)
# TODO(ulan): Add frame time discrepancy once it is ported to TBMv2,
# see crbug.com/606841.
- options.SetTimelineBasedMetrics(['v8AndMemoryMetrics'])
+ options.SetTimelineBasedMetrics([
+ 'expectedQueueingTimeMetric', 'v8AndMemoryMetrics'])
# Setting an empty memory dump config disables periodic dumps.
options.config.chrome_trace_config.SetMemoryDumpConfig(
chrome_trace_config.MemoryDumpConfig())
@@ -119,7 +130,7 @@ class _InfiniteScrollBenchmark(perf_benchmark.PerfBenchmark):
@classmethod
def ValueCanBeAddedPredicate(cls, value, _):
- return 'v8' in value.name
+ return ('v8' in value.name) or ('eqt' in value.name)
@classmethod
def ShouldTearDownStateAfterEachStoryRun(cls):
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698