Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(417)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: services/ui/demo/mus_demo.cc

Issue 2764433002: Fix destruction order in mus_demo (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: services/ui/demo/mus_demo.cc
diff --git a/services/ui/demo/mus_demo.cc b/services/ui/demo/mus_demo.cc
index 7afba5693af4cae100e7e13c0f09af916494b989..81fd477527a878d18c22b737d5fb4bc440a2e110 100644
--- a/services/ui/demo/mus_demo.cc
+++ b/services/ui/demo/mus_demo.cc
@@ -24,6 +24,8 @@ MusDemo::MusDemo() {}
MusDemo::~MusDemo() {
display::Screen::SetScreenInstance(nullptr);
+ window_tree_data_list_.clear();
+ window_tree_client_.reset();
fwang 2017/03/20 11:45:39 Maybe add a comment that the destruction order is
kylechar 2017/03/20 13:27:42 Yes, please add a comment explaining the order.
msisov 2017/03/20 14:04:01 Done.
}
void MusDemo::AddPrimaryDisplay(const display::Display& display) {
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698