Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(310)

Unified Diff: gpu/command_buffer/service/gles2_cmd_decoder_passthrough_handlers_autogen.cc

Issue 2764403002: Make sure buffers are large enough to hold the Result structure. (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « gpu/command_buffer/service/gles2_cmd_decoder_passthrough_handlers.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: gpu/command_buffer/service/gles2_cmd_decoder_passthrough_handlers_autogen.cc
diff --git a/gpu/command_buffer/service/gles2_cmd_decoder_passthrough_handlers_autogen.cc b/gpu/command_buffer/service/gles2_cmd_decoder_passthrough_handlers_autogen.cc
index bc19ef16bfc1b9624d004482a416c6f462e4000e..d4eb37e7fcb6e444fa61275e4ed0ce2ed2845c5f 100644
--- a/gpu/command_buffer/service/gles2_cmd_decoder_passthrough_handlers_autogen.cc
+++ b/gpu/command_buffer/service/gles2_cmd_decoder_passthrough_handlers_autogen.cc
@@ -1079,7 +1079,7 @@ error::Error GLES2DecoderPassthroughImpl::HandleGetBooleanv(
unsigned int buffer_size = 0;
typedef cmds::GetBooleanv::Result Result;
Result* result = GetSharedMemoryAndSizeAs<Result*>(
- c.params_shm_id, c.params_shm_offset, &buffer_size);
+ c.params_shm_id, c.params_shm_offset, sizeof(Result), &buffer_size);
GLboolean* params = result ? result->GetData() : NULL;
if (params == NULL) {
return error::kOutOfBounds;
@@ -1109,7 +1109,7 @@ error::Error GLES2DecoderPassthroughImpl::HandleGetBufferParameteri64v(
unsigned int buffer_size = 0;
typedef cmds::GetBufferParameteri64v::Result Result;
Result* result = GetSharedMemoryAndSizeAs<Result*>(
- c.params_shm_id, c.params_shm_offset, &buffer_size);
+ c.params_shm_id, c.params_shm_offset, sizeof(Result), &buffer_size);
GLint64* params = result ? result->GetData() : NULL;
if (params == NULL) {
return error::kOutOfBounds;
@@ -1139,7 +1139,7 @@ error::Error GLES2DecoderPassthroughImpl::HandleGetBufferParameteriv(
unsigned int buffer_size = 0;
typedef cmds::GetBufferParameteriv::Result Result;
Result* result = GetSharedMemoryAndSizeAs<Result*>(
- c.params_shm_id, c.params_shm_offset, &buffer_size);
+ c.params_shm_id, c.params_shm_offset, sizeof(Result), &buffer_size);
GLint* params = result ? result->GetData() : NULL;
if (params == NULL) {
return error::kOutOfBounds;
@@ -1186,7 +1186,7 @@ error::Error GLES2DecoderPassthroughImpl::HandleGetFloatv(
unsigned int buffer_size = 0;
typedef cmds::GetFloatv::Result Result;
Result* result = GetSharedMemoryAndSizeAs<Result*>(
- c.params_shm_id, c.params_shm_offset, &buffer_size);
+ c.params_shm_id, c.params_shm_offset, sizeof(Result), &buffer_size);
GLfloat* params = result ? result->GetData() : NULL;
if (params == NULL) {
return error::kOutOfBounds;
@@ -1219,7 +1219,7 @@ GLES2DecoderPassthroughImpl::HandleGetFramebufferAttachmentParameteriv(
unsigned int buffer_size = 0;
typedef cmds::GetFramebufferAttachmentParameteriv::Result Result;
Result* result = GetSharedMemoryAndSizeAs<Result*>(
- c.params_shm_id, c.params_shm_offset, &buffer_size);
+ c.params_shm_id, c.params_shm_offset, sizeof(Result), &buffer_size);
GLint* params = result ? result->GetData() : NULL;
if (params == NULL) {
return error::kOutOfBounds;
@@ -1248,7 +1248,7 @@ error::Error GLES2DecoderPassthroughImpl::HandleGetInteger64v(
unsigned int buffer_size = 0;
typedef cmds::GetInteger64v::Result Result;
Result* result = GetSharedMemoryAndSizeAs<Result*>(
- c.params_shm_id, c.params_shm_offset, &buffer_size);
+ c.params_shm_id, c.params_shm_offset, sizeof(Result), &buffer_size);
GLint64* params = result ? result->GetData() : NULL;
if (params == NULL) {
return error::kOutOfBounds;
@@ -1277,7 +1277,7 @@ error::Error GLES2DecoderPassthroughImpl::HandleGetIntegeri_v(
unsigned int buffer_size = 0;
typedef cmds::GetIntegeri_v::Result Result;
Result* result = GetSharedMemoryAndSizeAs<Result*>(
- c.data_shm_id, c.data_shm_offset, &buffer_size);
+ c.data_shm_id, c.data_shm_offset, sizeof(Result), &buffer_size);
GLint* data = result ? result->GetData() : NULL;
if (data == NULL) {
return error::kOutOfBounds;
@@ -1306,7 +1306,7 @@ error::Error GLES2DecoderPassthroughImpl::HandleGetInteger64i_v(
unsigned int buffer_size = 0;
typedef cmds::GetInteger64i_v::Result Result;
Result* result = GetSharedMemoryAndSizeAs<Result*>(
- c.data_shm_id, c.data_shm_offset, &buffer_size);
+ c.data_shm_id, c.data_shm_offset, sizeof(Result), &buffer_size);
GLint64* data = result ? result->GetData() : NULL;
if (data == NULL) {
return error::kOutOfBounds;
@@ -1334,7 +1334,7 @@ error::Error GLES2DecoderPassthroughImpl::HandleGetIntegerv(
unsigned int buffer_size = 0;
typedef cmds::GetIntegerv::Result Result;
Result* result = GetSharedMemoryAndSizeAs<Result*>(
- c.params_shm_id, c.params_shm_offset, &buffer_size);
+ c.params_shm_id, c.params_shm_offset, sizeof(Result), &buffer_size);
GLint* params = result ? result->GetData() : NULL;
if (params == NULL) {
return error::kOutOfBounds;
@@ -1363,7 +1363,7 @@ error::Error GLES2DecoderPassthroughImpl::HandleGetProgramiv(
unsigned int buffer_size = 0;
typedef cmds::GetProgramiv::Result Result;
Result* result = GetSharedMemoryAndSizeAs<Result*>(
- c.params_shm_id, c.params_shm_offset, &buffer_size);
+ c.params_shm_id, c.params_shm_offset, sizeof(Result), &buffer_size);
GLint* params = result ? result->GetData() : NULL;
if (params == NULL) {
return error::kOutOfBounds;
@@ -1393,7 +1393,7 @@ error::Error GLES2DecoderPassthroughImpl::HandleGetRenderbufferParameteriv(
unsigned int buffer_size = 0;
typedef cmds::GetRenderbufferParameteriv::Result Result;
Result* result = GetSharedMemoryAndSizeAs<Result*>(
- c.params_shm_id, c.params_shm_offset, &buffer_size);
+ c.params_shm_id, c.params_shm_offset, sizeof(Result), &buffer_size);
GLint* params = result ? result->GetData() : NULL;
if (params == NULL) {
return error::kOutOfBounds;
@@ -1424,7 +1424,7 @@ error::Error GLES2DecoderPassthroughImpl::HandleGetSamplerParameterfv(
unsigned int buffer_size = 0;
typedef cmds::GetSamplerParameterfv::Result Result;
Result* result = GetSharedMemoryAndSizeAs<Result*>(
- c.params_shm_id, c.params_shm_offset, &buffer_size);
+ c.params_shm_id, c.params_shm_offset, sizeof(Result), &buffer_size);
GLfloat* params = result ? result->GetData() : NULL;
if (params == NULL) {
return error::kOutOfBounds;
@@ -1455,7 +1455,7 @@ error::Error GLES2DecoderPassthroughImpl::HandleGetSamplerParameteriv(
unsigned int buffer_size = 0;
typedef cmds::GetSamplerParameteriv::Result Result;
Result* result = GetSharedMemoryAndSizeAs<Result*>(
- c.params_shm_id, c.params_shm_offset, &buffer_size);
+ c.params_shm_id, c.params_shm_offset, sizeof(Result), &buffer_size);
GLint* params = result ? result->GetData() : NULL;
if (params == NULL) {
return error::kOutOfBounds;
@@ -1485,7 +1485,7 @@ error::Error GLES2DecoderPassthroughImpl::HandleGetShaderiv(
unsigned int buffer_size = 0;
typedef cmds::GetShaderiv::Result Result;
Result* result = GetSharedMemoryAndSizeAs<Result*>(
- c.params_shm_id, c.params_shm_offset, &buffer_size);
+ c.params_shm_id, c.params_shm_offset, sizeof(Result), &buffer_size);
GLint* params = result ? result->GetData() : NULL;
if (params == NULL) {
return error::kOutOfBounds;
@@ -1514,7 +1514,7 @@ error::Error GLES2DecoderPassthroughImpl::HandleGetSynciv(
unsigned int buffer_size = 0;
typedef cmds::GetSynciv::Result Result;
Result* result = GetSharedMemoryAndSizeAs<Result*>(
- c.values_shm_id, c.values_shm_offset, &buffer_size);
+ c.values_shm_id, c.values_shm_offset, sizeof(Result), &buffer_size);
GLint* values = result ? result->GetData() : NULL;
if (values == NULL) {
return error::kOutOfBounds;
@@ -1543,7 +1543,7 @@ error::Error GLES2DecoderPassthroughImpl::HandleGetTexParameterfv(
unsigned int buffer_size = 0;
typedef cmds::GetTexParameterfv::Result Result;
Result* result = GetSharedMemoryAndSizeAs<Result*>(
- c.params_shm_id, c.params_shm_offset, &buffer_size);
+ c.params_shm_id, c.params_shm_offset, sizeof(Result), &buffer_size);
GLfloat* params = result ? result->GetData() : NULL;
if (params == NULL) {
return error::kOutOfBounds;
@@ -1573,7 +1573,7 @@ error::Error GLES2DecoderPassthroughImpl::HandleGetTexParameteriv(
unsigned int buffer_size = 0;
typedef cmds::GetTexParameteriv::Result Result;
Result* result = GetSharedMemoryAndSizeAs<Result*>(
- c.params_shm_id, c.params_shm_offset, &buffer_size);
+ c.params_shm_id, c.params_shm_offset, sizeof(Result), &buffer_size);
GLint* params = result ? result->GetData() : NULL;
if (params == NULL) {
return error::kOutOfBounds;
@@ -1603,7 +1603,7 @@ error::Error GLES2DecoderPassthroughImpl::HandleGetVertexAttribfv(
unsigned int buffer_size = 0;
typedef cmds::GetVertexAttribfv::Result Result;
Result* result = GetSharedMemoryAndSizeAs<Result*>(
- c.params_shm_id, c.params_shm_offset, &buffer_size);
+ c.params_shm_id, c.params_shm_offset, sizeof(Result), &buffer_size);
GLfloat* params = result ? result->GetData() : NULL;
if (params == NULL) {
return error::kOutOfBounds;
@@ -1633,7 +1633,7 @@ error::Error GLES2DecoderPassthroughImpl::HandleGetVertexAttribiv(
unsigned int buffer_size = 0;
typedef cmds::GetVertexAttribiv::Result Result;
Result* result = GetSharedMemoryAndSizeAs<Result*>(
- c.params_shm_id, c.params_shm_offset, &buffer_size);
+ c.params_shm_id, c.params_shm_offset, sizeof(Result), &buffer_size);
GLint* params = result ? result->GetData() : NULL;
if (params == NULL) {
return error::kOutOfBounds;
@@ -1663,7 +1663,7 @@ error::Error GLES2DecoderPassthroughImpl::HandleGetVertexAttribIiv(
unsigned int buffer_size = 0;
typedef cmds::GetVertexAttribIiv::Result Result;
Result* result = GetSharedMemoryAndSizeAs<Result*>(
- c.params_shm_id, c.params_shm_offset, &buffer_size);
+ c.params_shm_id, c.params_shm_offset, sizeof(Result), &buffer_size);
GLint* params = result ? result->GetData() : NULL;
if (params == NULL) {
return error::kOutOfBounds;
@@ -1693,7 +1693,7 @@ error::Error GLES2DecoderPassthroughImpl::HandleGetVertexAttribIuiv(
unsigned int buffer_size = 0;
typedef cmds::GetVertexAttribIuiv::Result Result;
Result* result = GetSharedMemoryAndSizeAs<Result*>(
- c.params_shm_id, c.params_shm_offset, &buffer_size);
+ c.params_shm_id, c.params_shm_offset, sizeof(Result), &buffer_size);
GLuint* params = result ? result->GetData() : NULL;
if (params == NULL) {
return error::kOutOfBounds;
« no previous file with comments | « gpu/command_buffer/service/gles2_cmd_decoder_passthrough_handlers.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698