[regexp] Named capture support for callable replacements

test/mjsunit/harmony/regexp-named-captures.js

Index: test/mjsunit/harmony/regexp-named-captures.js
diff --git a/test/mjsunit/harmony/regexp-named-captures.js b/test/mjsunit/harmony/regexp-named-captures.js
index 190566db4cf8df3749b228ce6cc569b3c1e9cb70..e41994cf0a770cf8e01aa7f45314eb25e19e230c 100644
--- a/test/mjsunit/harmony/regexp-named-captures.js
+++ b/test/mjsunit/harmony/regexp-named-captures.js
@@ -96,3 +96,115 @@ assertThrows('/(?<𐒤>a)/u', SyntaxError);  // ID_Continue but not ID_Start.
 // The '__proto__' property on the groups object.
 assertEquals(undefined, /(?<a>.)/u.exec("a").groups.__proto__);
 assertEquals("a", /(?<__proto__>a)/u.exec("a").groups.__proto__);
+
+// @@replace with a callable replacement argument (no named captures).
+{
+  let result = "abcd".replace(/(.)(.)/u, (match, fst, snd, offset, str) => {
+    assertEquals("ab", match);
+    assertEquals("a", fst);
+    assertEquals("b", snd);
+    assertEquals(0, offset);
+    assertEquals("abcd", str);
+    return `${snd}${fst}`;
+  });
+  assertEquals("bacd", result);
+}
+
+// @@replace with a callable replacement argument (global, named captures).
+{
+  let i = 0;
+  let result = "abcd".replace(/(?<fst>.)(?<snd>.)/gu,
+      (match, fst, snd, groups, offset, str) => {
+    if (i == 0) {
+      assertEquals("ab", match);
+      assertEquals("a", groups.fst);
+      assertEquals("b", groups.snd);
+      assertEquals("a", fst);
+      assertEquals("b", snd);
+      assertEquals(0, offset);
+      assertEquals("abcd", str);
+    } else if (i == 1) {
+      assertEquals("cd", match);
+      assertEquals("c", groups.fst);
+      assertEquals("d", groups.snd);
+      assertEquals("c", fst);
+      assertEquals("d", snd);
+      assertEquals(2, offset);
+      assertEquals("abcd", str);
+    } else {
+      assertUnreachable();
+    }
+    i++;
+    return `${groups.snd}${groups.fst}`;
+  });
+  assertEquals("badc", result);
+}
+
+// @@replace with a callable replacement argument (non-global, named captures).
+{
+  let result = "abcd".replace(/(?<fst>.)(?<snd>.)/u,
+      (match, fst, snd, groups, offset, str) => {
+    assertEquals("ab", match);
+    assertEquals("a", groups.fst);
+    assertEquals("b", groups.snd);
+    assertEquals("a", fst);
+    assertEquals("b", snd);
+    assertEquals(0, offset);
+    assertEquals("abcd", str);
+    return `${groups.snd}${groups.fst}`;
+  });
+  assertEquals("bacd", result);
+}
+
+function toSlowMode(re) {
+  re.exec = (str) => RegExp.prototype.exec.call(re, str);
+  return re;
+}
+
+// @@replace with a callable replacement argument (slow, global,
+// named captures).
+{
+  let i = 0;
+  let re = toSlowMode(/(?<fst>.)(?<snd>.)/gu);
+  let result = "abcd".replace(re, (match, fst, snd, groups, offset, str) => {
+    if (i == 0) {
+      assertEquals("ab", match);
+      assertEquals("a", groups.fst);
+      assertEquals("b", groups.snd);
+      assertEquals("a", fst);
+      assertEquals("b", snd);
+      assertEquals(0, offset);
+      assertEquals("abcd", str);
+    } else if (i == 1) {
+      assertEquals("cd", match);
+      assertEquals("c", groups.fst);
+      assertEquals("d", groups.snd);
+      assertEquals("c", fst);
+      assertEquals("d", snd);
+      assertEquals(2, offset);
+      assertEquals("abcd", str);
+    } else {
+      assertUnreachable();
+    }
+    i++;
+    return `${groups.snd}${groups.fst}`;
+  });
+  assertEquals("badc", result);
+}
+
+// @@replace with a callable replacement argument (slow, non-global,
+// named captures).
+{
+  let re = toSlowMode(/(?<fst>.)(?<snd>.)/u);
+  let result = "abcd".replace(re, (match, fst, snd, groups, offset, str) => {
+    assertEquals("ab", match);
+    assertEquals("a", groups.fst);
+    assertEquals("b", groups.snd);
+    assertEquals("a", fst);
+    assertEquals("b", snd);
+    assertEquals(0, offset);
+    assertEquals("abcd", str);
+    return `${groups.snd}${groups.fst}`;
+  });
+  assertEquals("bacd", result);
+}

[Yang, 2017/03/23 14:58:22]

Not directly related to this CL. Could we have some tests for interactions with

- lookbehind assertions
- nested groups
- number for group names

[jgruber, 2017/03/24 14:06:46]

Acknowledged.