Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(714)

Unified Diff: third_party/WebKit/Source/core/paint/PartPainter.cpp

Issue 2764313002: Move plugins to be stored in HTMLPlugInElement. (Closed)
Patch Set: Fix PartPainter CHECK to !plugin rather than must be frame. Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/paint/PartPainter.cpp
diff --git a/third_party/WebKit/Source/core/paint/PartPainter.cpp b/third_party/WebKit/Source/core/paint/PartPainter.cpp
index 15736e971c50a412b603685a60486dde7eba23f7..79637ef05808a5dee781ce4ad040170f7405a4ce 100644
--- a/third_party/WebKit/Source/core/paint/PartPainter.cpp
+++ b/third_party/WebKit/Source/core/paint/PartPainter.cpp
@@ -74,6 +74,7 @@ void PartPainter::paint(const PaintInfo& paintInfo,
// the crashes we see in FrameViewBase painting are due to a destroyed
// LayoutPart object.
CHECK(m_layoutPart.node());
+ CHECK(!m_layoutPart.frameViewBase()->isPluginView());
Optional<RoundedInnerRectClipper> clipper;
if (m_layoutPart.style()->hasBorderRadius()) {
if (borderRect.isEmpty())
@@ -120,6 +121,7 @@ void PartPainter::paintContents(const PaintInfo& paintInfo,
FrameViewBase* frameViewBase = m_layoutPart.frameViewBase();
CHECK(frameViewBase);
+ CHECK(!frameViewBase->isPluginView());
IntPoint paintLocation(roundedIntPoint(
adjustedPaintOffset + m_layoutPart.replacedContentRect().location()));

Powered by Google App Engine
This is Rietveld 408576698