Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(539)

Unified Diff: third_party/WebKit/Source/core/paint/PartPainter.cpp

Issue 2764313002: Move plugins to be stored in HTMLPlugInElement. (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/paint/PartPainter.cpp
diff --git a/third_party/WebKit/Source/core/paint/PartPainter.cpp b/third_party/WebKit/Source/core/paint/PartPainter.cpp
index 15736e971c50a412b603685a60486dde7eba23f7..70464c310573e49c78f55ceb0d82ee1a726ef55c 100644
--- a/third_party/WebKit/Source/core/paint/PartPainter.cpp
+++ b/third_party/WebKit/Source/core/paint/PartPainter.cpp
@@ -69,6 +69,7 @@ void PartPainter::paint(const PaintInfo& paintInfo,
if (paintInfo.phase != PaintPhaseForeground)
return;
+ // TODO(joelhockey): Do we need special handling for plugins?
if (m_layoutPart.frameViewBase()) {
// TODO(schenney) crbug.com/93805 Speculative release assert to verify that
// the crashes we see in FrameViewBase painting are due to a destroyed
@@ -118,6 +119,7 @@ void PartPainter::paintContents(const PaintInfo& paintInfo,
const LayoutPoint& paintOffset) {
LayoutPoint adjustedPaintOffset = paintOffset + m_layoutPart.location();
+ // TODO(joelhockey): Do we need special handling for plugins?
FrameViewBase* frameViewBase = m_layoutPart.frameViewBase();
CHECK(frameViewBase);

Powered by Google App Engine
This is Rietveld 408576698