Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Unified Diff: third_party/WebKit/Source/core/layout/LayoutEmbeddedObject.cpp

Issue 2764313002: Move plugins to be stored in HTMLPlugInElement. (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/layout/LayoutEmbeddedObject.cpp
diff --git a/third_party/WebKit/Source/core/layout/LayoutEmbeddedObject.cpp b/third_party/WebKit/Source/core/layout/LayoutEmbeddedObject.cpp
index c5b3b315221c31ecf67e689a596ba87c22b0587c..a544162df63fd69b1e4735c74563374caef04083 100644
--- a/third_party/WebKit/Source/core/layout/LayoutEmbeddedObject.cpp
+++ b/third_party/WebKit/Source/core/layout/LayoutEmbeddedObject.cpp
@@ -135,6 +135,8 @@ void LayoutEmbeddedObject::layout() {
updateLayerTransformAfterLayout();
+ // TODO(joelhockey): Can this FrameViewBase be a plugin?
+ // If so, need to access plugin differently to this.
haraken 2017/03/22 15:32:33 It shouldn't, since this is using frameView()->add
joelhockey 2017/03/27 06:42:21 Thanks. Yes, that makes sense.
FrameViewBase* frameViewBase = this->frameViewBase();
if (!frameViewBase && frameView())
frameView()->addPartToUpdate(*this);

Powered by Google App Engine
This is Rietveld 408576698