Pepper: Nexe downloading out of the trusted plugin.

components/nacl/renderer/file_downloader.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <string>
 
 #include "base/callback.h"
+#include "base/files/file.h"
 #include "ppapi/c/private/ppb_nacl_private.h"
 #include "third_party/WebKit/public/platform/WebURLLoaderClient.h"
 
 namespace blink {
 struct WebURLError;
 class WebURLLoader;
 class WebURLResponse;
 }
 
 namespace nacl {
 
-// Downloads a NaCl manifest (.nmf) and returns the contents of the file to
-// caller through a callback.
-class ManifestDownloader : public blink::WebURLLoaderClient {
+// Downloads a file and writes the contents to a specified file open for
+// writing.
+class FileDownloader : public blink::WebURLLoaderClient {
  public:
-  typedef base::Callback<void(PP_NaClError, const std::string&)>
-      ManifestDownloaderCallback;
+  enum Status {
+    SUCCESS,
+    ACCESS_DENIED,  // Access denied
+    FAILED          // Generic failure
+  };
+  typedef base::Callback<void(Status, int)> FileDownloaderCallback;

[bbudge, 2014/05/12 22:32:06]

name suggestion: Callback or StatusCallback

[teravest, 2014/05/13 17:05:32]

Done.

+  typedef base::Callback<void(int64_t, int64_t)> ProgressCallback;
 
-  ManifestDownloader(bool is_installed, ManifestDownloaderCallback cb);
-  virtual ~ManifestDownloader();
+  FileDownloader(base::PlatformFile file,
+                 FileDownloaderCallback cb);

[bbudge, 2014/05/12 22:32:06]

nit: fits on a single line.

[teravest, 2014/05/13 17:05:32]

Done.

+
+  // Creates a FileDownloader that notifies the caller about download progress.
+  FileDownloader(base::PlatformFile file,
+                 FileDownloaderCallback cb,
+                 ProgressCallback progress_cb);
+
+  virtual ~FileDownloader();
 
  private:
   // WebURLLoaderClient implementation.
   virtual void didReceiveResponse(blink::WebURLLoader* loader,
                                   const blink::WebURLResponse& response);
   virtual void didReceiveData(blink::WebURLLoader* loader,
                               const char* data,
                               int data_length,
                               int encoded_data_length);
   virtual void didFinishLoading(blink::WebURLLoader* loader,
                                 double finish_time,
                                 int64_t total_encoded_data_length);
   virtual void didFail(blink::WebURLLoader* loader,
                        const blink::WebURLError& error);
 
-  bool is_installed_;
-  ManifestDownloaderCallback cb_;
-  std::string buffer_;
+  base::PlatformFile file_;
+  FileDownloaderCallback cb_;
+  ProgressCallback progress_cb_;
   int status_code_;
-  PP_NaClError pp_nacl_error_;
+  int64_t total_bytes_received_;
+  int64_t total_bytes_to_be_received_;
+  Status status_;
 };
 
 }  // namespace nacl