Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Unified Diff: third_party/WebKit/Source/devtools/front_end/timeline/TimelinePanel.js

Issue 2764123003: DevTools: Add a link to JS CPU profiler migration notes. (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/devtools/front_end/timeline/TimelinePanel.js
diff --git a/third_party/WebKit/Source/devtools/front_end/timeline/TimelinePanel.js b/third_party/WebKit/Source/devtools/front_end/timeline/TimelinePanel.js
index ee00e525dfeeecbcde45bfee38862a59910791d2..37aeb47220b9ff52645f1efaffdb304584b6ace5 100644
--- a/third_party/WebKit/Source/devtools/front_end/timeline/TimelinePanel.js
+++ b/third_party/WebKit/Source/devtools/front_end/timeline/TimelinePanel.js
@@ -645,6 +645,10 @@ Timeline.TimelinePanel = class extends UI.Panel {
var learnMoreNode = UI.createExternalLink(
'https://developers.google.com/web/tools/chrome-devtools/evaluate-performance/',
Common.UIString('Learn\xa0more'));
+ var learnMoreMigrationNode = UI.createExternalLink(
+ 'https://developers.google.com/web/updates/2016/12/devtools-javascript-cpu-profile-migration',
+ Common.UIString('Learn\xa0more'));
+
var recordKey =
encloseWithTag('b', UI.shortcutRegistry.shortcutDescriptorsForAction('timeline.toggle-recording')[0].name);
var reloadKey = encloseWithTag('b', UI.shortcutRegistry.shortcutDescriptorsForAction('main.reload')[0].name);
@@ -659,12 +663,12 @@ Timeline.TimelinePanel = class extends UI.Panel {
centered.createChild('p').appendChild(UI.formatLocalized(
'Click the record button %s or hit %s to capture a new recording.\n' +
- 'Click the reload button %s or hit %s to record and evaluate the page load.',
+ 'Click the reload button %s or hit %s to record and evaluate the page load.',
[recordButton, recordKey, reloadButton, reloadKey]));
centered.createChild('p').appendChild(UI.formatLocalized(
'After recording, select an area of interest in the overview by dragging.\n' +
- 'Then, zoom and pan the timeline with the mousewheel or %s keys.\n%s',
+ 'Then, zoom and pan the timeline with the mousewheel or %s keys.\n%s',
[navigateNode, learnMoreNode]));
var cpuProfilerHintSetting = Common.settings.createSetting('timelineShowProfilerHint', true);
@@ -677,10 +681,10 @@ Timeline.TimelinePanel = class extends UI.Panel {
}, false);
var performanceSpan = encloseWithTag('b', Common.UIString('Performance'));
warning.createChild('div').appendChild(UI.formatLocalized(
- 'The %s panel provides the combined functionality of Timeline and CPU profiler.%s' +
- 'The JavaScript CPU profiler will be removed shortly. Meanwhile, it\'s available under ' +
- '%s \u2192 More Tools \u2192 JavaScript Profiler.',
- [performanceSpan, createElement('p'), UI.Icon.create('largeicon-menu')]));
+ `The %s panel provides the combined functionality of Timeline and JavaScript CPU profiler. %s%s` +
+ `The JavaScript CPU profiler will be removed shortly. Meanwhile, it's available under ` +
+ `%s \u2192 More Tools \u2192 JavaScript Profiler.`,
+ [performanceSpan, learnMoreMigrationNode, createElement('p'), UI.Icon.create('largeicon-menu')]));
}
this._landingPage.show(this._statusPaneContainer);
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698