Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(476)

Unified Diff: test/message/type-profile/collect-type-profile.js

Issue 2764113002: [type-profile] Handle returns correctly. (Closed)
Patch Set: Rebase. Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/runtime/runtime-test.cc ('k') | test/message/type-profile/collect-type-profile.out » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/message/type-profile/collect-type-profile.js
diff --git a/test/message/type-profile/collect-type-profile.js b/test/message/type-profile/collect-type-profile.js
index d6876743c6f3085e60c5224c6a3ffbf3637524ab..47dff72b8ae5587fdba47a4c9f07c96f1240c17c 100644
--- a/test/message/type-profile/collect-type-profile.js
+++ b/test/message/type-profile/collect-type-profile.js
@@ -1,4 +1,4 @@
-// Copyright 2016 the V8 project authors. All rights reserved.
+// Copyright 2017 the V8 project authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
@@ -39,7 +39,6 @@ function testReturnOfNonVariable() {
}
// Return statement is reached but its expression is never really returned.
-// TODO(franzih): The only return type should be 'string'.
function try_finally() {
try {
return 23;
@@ -50,16 +49,12 @@ function try_finally() {
try_finally();
%PrintTypeProfile(try_finally);
-// TODO(franzih): 'undefined' should be the return type.
function fall_off() {
//nothing
}
fall_off();
%PrintTypeProfile(fall_off);
-
-
-
testReturnOfNonVariable();
throw "throw otherwise test fails with --stress-opt";
« no previous file with comments | « src/runtime/runtime-test.cc ('k') | test/message/type-profile/collect-type-profile.out » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698