Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Unified Diff: src/ast/ast.h

Issue 2764113002: [type-profile] Handle returns correctly. (Closed)
Patch Set: Rebase. Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/ast/ast.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/ast/ast.h
diff --git a/src/ast/ast.h b/src/ast/ast.h
index de603f8ad3fe2b6199f43e3beca6131cf99d0106..0c6608e9645a92c6ea2c3e2d08968557fa17640d 100644
--- a/src/ast/ast.h
+++ b/src/ast/ast.h
@@ -904,15 +904,6 @@ class ReturnStatement final : public JumpStatement {
Type type() const { return TypeField::decode(bit_field_); }
bool is_async_return() const { return type() == kAsyncReturn; }
- FeedbackSlot TypeProfileSlot() const {
- DCHECK(HasTypeProfileSlot());
- return type_profile_slot_;
- }
-
- void SetTypeProfileSlot(FeedbackSlot slot) { type_profile_slot_ = slot; }
-
- bool HasTypeProfileSlot() const { return !type_profile_slot_.IsInvalid(); }
-
private:
friend class AstNodeFactory;
@@ -921,8 +912,6 @@ class ReturnStatement final : public JumpStatement {
bit_field_ |= TypeField::encode(type);
}
- FeedbackSlot type_profile_slot_;
-
Expression* expression_;
class TypeField
@@ -2425,17 +2414,9 @@ class Assignment final : public Expression {
}
void AssignFeedbackSlots(FeedbackVectorSpec* spec, LanguageMode language_mode,
- FeedbackSlotCache* cache,
- bool collect_type_profile = false);
+ FeedbackSlotCache* cache);
FeedbackSlot AssignmentSlot() const { return slot_; }
- FeedbackSlot TypeProfileSlot() const {
- DCHECK(HasTypeProfileSlot());
- return type_profile_slot_;
- }
-
- bool HasTypeProfileSlot() const { return !type_profile_slot_.IsInvalid(); }
-
private:
friend class AstNodeFactory;
@@ -2457,8 +2438,6 @@ class Assignment final : public Expression {
Expression* value_;
BinaryOperation* binary_operation_;
SmallMapList receiver_types_;
-
- FeedbackSlot type_profile_slot_;
};
@@ -2606,7 +2585,10 @@ class FunctionLiteral final : public Expression {
literal_feedback_slot_ = spec->AddCreateClosureSlot();
}
+ void SetTypeProfileSlot(FeedbackSlot slot) { type_profile_slot_ = slot; }
+
FeedbackSlot LiteralFeedbackSlot() const { return literal_feedback_slot_; }
+ FeedbackSlot TypeProfileSlot() const { return type_profile_slot_; }
static bool NeedsHomeObject(Expression* expr);
@@ -2769,6 +2751,7 @@ class FunctionLiteral final : public Expression {
AstProperties ast_properties_;
int function_literal_id_;
FeedbackSlot literal_feedback_slot_;
+ FeedbackSlot type_profile_slot_;
};
// Property is used for passing information
« no previous file with comments | « no previous file | src/ast/ast.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698