Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Unified Diff: test/message/type-profile/collect-type-profile.js

Issue 2764113002: [type-profile] Handle returns correctly. (Closed)
Patch Set: Private slot. Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: test/message/type-profile/collect-type-profile.js
diff --git a/test/message/type-profile/collect-type-profile.js b/test/message/type-profile/collect-type-profile.js
index d6876743c6f3085e60c5224c6a3ffbf3637524ab..d42e2366b37acbc1ae07b4a570a2193331ecd5d4 100644
--- a/test/message/type-profile/collect-type-profile.js
+++ b/test/message/type-profile/collect-type-profile.js
@@ -39,7 +39,6 @@ function testReturnOfNonVariable() {
}
// Return statement is reached but its expression is never really returned.
-// TODO(franzih): The only return type should be 'string'.
function try_finally() {
try {
return 23;
@@ -50,7 +49,6 @@ function try_finally() {
try_finally();
%PrintTypeProfile(try_finally);
-// TODO(franzih): 'undefined' should be the return type.
function fall_off() {
//nothing
}

Powered by Google App Engine
This is Rietveld 408576698