Settings reset prompt: the dialog should have focus when shown.

chrome/browser/safe_browsing/settings_reset_prompt/settings_reset_prompt_controller.cc

 // Copyright 2017 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/safe_browsing/settings_reset_prompt/settings_reset_prompt_controller.h"
 
 #include <utility>
 
 #include "base/bind.h"
 #include "base/bind_helpers.h"
@@ skipping 53 matching lines @@
   if (!model->ShouldPromptForReset())
     return;
 
   Profile* profile = model->profile();
 
   // Ensure that there is at least one non-incognito browser open for the
   // profile before attempting to show the dialog.
   if (!chrome::FindTabbedBrowser(profile, /*match_original_profiles=*/false))
     return;
 
-  chrome::ScopedTabbedBrowserDisplayer displayer(profile);
+  // First, find a browser window and show it, and only then show the dialog so
+  // that the dialog will have focus.
+  Browser* browser = nullptr;
+  {
+    chrome::ScopedTabbedBrowserDisplayer displayer(profile);

[sky, 2017/03/21 20:36:01]

If a new browser is created by ScopedTabbedBrowserDisplayer then I don't see you
adding anything to it, which would result in an empty tabbed-browser and all
sorts of problems. You should only use ScopedTabbedBrowserDisplayer  if you're
going to add a tab to it.

[alito2, 2017/03/21 20:44:17]

Just above this line, I do make sure that there is at least one non-incognito
tabbed browser already open. I think that should be enough to ensure that we
don't end up in a weird situation?

Another option is to explicitly use that tabbed browser found above and slightly
duplicate the code in the ScopedTabbedBrowserDisplayer's destructor.

[sky, 2017/03/21 20:52:18]

Indeed. In that case you should use the return value from FindTabbedBrowser and
you should have no need for ScopedTabbedBrowserDisplayer.

[alito, 2017/03/21 21:02:42]

Done.

+    browser = displayer.browser();
+  }
   // The |SettingsResetPromptController| object will delete itself after the
   // reset prompt dialog has been closed.
   SettingsResetPromptController::ShowSettingsResetPrompt(
-      displayer.browser(), new SettingsResetPromptController(std::move(model)));
+      browser, new SettingsResetPromptController(std::move(model)));
 }
 
 void MaybeShowSettingsResetPrompt(
     std::unique_ptr<SettingsResetPromptConfig> config) {
   DCHECK(config);
 
   Browser* browser = chrome::FindLastActive();
   if (!browser)
     return;
 
@@ skipping 145 matching lines @@
   if (!config)
     return;
 
   base::TimeDelta delay = config->delay_before_prompt();
   content::BrowserThread::PostDelayedTask(
       content::BrowserThread::UI, FROM_HERE,
       base::Bind(MaybeShowSettingsResetPrompt, base::Passed(&config)), delay);
 }
 
 }  // namespace safe_browsing