DevTools: Do not apply first suggestion in the classes pane on enter

third_party/WebKit/Source/devtools/front_end/ui/TextPrompt.js

 /*
  * Copyright (C) 2008 Apple Inc.  All rights reserved.
  * Copyright (C) 2011 Google Inc.  All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  *
  * 1.  Redistributions of source code must retain the above copyright
  *     notice, this list of conditions and the following disclaimer.
@@ skipping 472 matching lines @@
 
     if (query + selectionRange.toString() !== fullWordRange.toString())
       return;
 
     var beforeRange = this._createRange();
     beforeRange.setStart(this._element, 0);
     beforeRange.setEnd(fullWordRange.startContainer, fullWordRange.startOffset);
     this._queryRange = new Common.TextRange(
         0, beforeRange.toString().length, 0, beforeRange.toString().length + fullWordRange.toString().length);
 
-    var shouldSelect = !this._disableDefaultSuggestionForEmptyInput || this.text();
+    var shouldSelect = !this._disableDefaultSuggestionForEmptyInput || !!this.text();

[kdzwinel, 2017/03/21 12:32:38]

not really related, but I found it while investigating original issue.
`updateSuggestions` expects `shouldSelect` (`selectHighestPriority`) to be a
boolean, before this change it was sometimes a string. BTW: why closure compiler
missed that?

http://i.imgur.com/XFEzuv4.png

[einbinder, 2017/03/21 23:30:08]

Good catch! I never trust that booleans in devtools are actually booleans. They
are often actually undefined.

     if (this._suggestBox) {
       this._suggestBox.updateSuggestions(
           this._boxForAnchorAtStart(selection, fullWordRange), completions, shouldSelect, !this._isCaretAtEndOfPrompt(),
           this.text());
     }
   }
 
   /**
    * @override
    * @param {string} suggestion
@@ skipping 130 matching lines @@
    */
   proxyElementForTests() {
     return this._proxyElement || null;
   }
 };
 
 UI.TextPrompt.DefaultAutocompletionTimeout = 250;
 
 /** @implements {Common.Emittable} */
 UI.TextPrompt.TextChangedEvent = class {};