Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(416)

Unified Diff: chrome/browser/memory/tab_manager.cc

Issue 2763933002: memory coordinator: Purge memory under memory pressure (Closed)
Patch Set: Use int64_t Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/memory/tab_manager.cc
diff --git a/chrome/browser/memory/tab_manager.cc b/chrome/browser/memory/tab_manager.cc
index 0cccbee9985264351bcb30aad2ee17f8b6d826cf..49ebd34b6481bc4dd0dd0e93f537fa7453409e31 100644
--- a/chrome/browser/memory/tab_manager.cc
+++ b/chrome/browser/memory/tab_manager.cc
@@ -361,15 +361,15 @@ bool TabManager::CanDiscardTab(int64_t target_web_contents_id) const {
return true;
}
-void TabManager::DiscardTab() {
+bool TabManager::DiscardTab() {
#if defined(OS_CHROMEOS)
// Call Chrome OS specific low memory handling process.
if (base::FeatureList::IsEnabled(features::kArcMemoryManagement)) {
delegate_->LowMemoryKill(GetUnsortedTabStats());
- return;
+ return false;
haraken 2017/03/24 11:55:38 Does this mean that the tab discarding not working
bashi 2017/03/28 03:15:30 Sorry I didn't check the implementation of LowMemo
}
#endif
- DiscardTabImpl();
+ return DiscardTabImpl() != nullptr;
}
WebContents* TabManager::DiscardTabById(int64_t target_web_contents_id) {

Powered by Google App Engine
This is Rietveld 408576698