Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(868)

Unified Diff: third_party/WebKit/Source/devtools/front_end/sdk/DOMModel.js

Issue 2763913002: Allow DOM.getNodeForLocation to skip to nearest non-shadow ancestor (Closed)
Patch Set: feedback Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/sdk/DOMModel.js
diff --git a/third_party/WebKit/Source/devtools/front_end/sdk/DOMModel.js b/third_party/WebKit/Source/devtools/front_end/sdk/DOMModel.js
index b6d4378f881608d8dfd771da4ddf8d60ced25743..ded89af42a459ff24bd011de839456b12216091d 100644
--- a/third_party/WebKit/Source/devtools/front_end/sdk/DOMModel.js
+++ b/third_party/WebKit/Source/devtools/front_end/sdk/DOMModel.js
@@ -1829,7 +1829,8 @@ SDK.DOMModel = class extends SDK.SDKModel {
* @param {function(?SDK.DOMNode)} callback
*/
nodeForLocation(x, y, callback) {
- this._agent.getNodeForLocation(x, y, mycallback.bind(this));
+ var showUAShadowDOM = Common.moduleSetting('showUAShadowDOM').get();
+ this._agent.getNodeForLocation(x, y, showUAShadowDOM, mycallback.bind(this));
peleg 2017/03/22 06:29:03 Is this what you had in mind for using moduleSetti
pfeldman 2017/03/22 17:32:46 I meant that you pass the boolean into DOMModel an
/**
* @param {?Protocol.Error} error

Powered by Google App Engine
This is Rietveld 408576698