third_party/WebKit/Source/core/inspector/browser_protocol.json - Issue 2763913002: Allow DOM.getNodeForLocation to skip to nearest non-shadow ancestor

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/inspector/browser_protocol.json

Issue 2763913002: Allow DOM.getNodeForLocation to skip to nearest non-shadow ancestor (Closed)

Patch Set: Remove brackets Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/LayoutTests/inspector-protocol/dom/dom-getNodeForLocation-skip-shadow-expected.txt ('K') | « third_party/WebKit/Source/core/inspector/InspectorDOMAgent.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/inspector/browser_protocol.json

diff --git a/third_party/WebKit/Source/core/inspector/browser_protocol.json b/third_party/WebKit/Source/core/inspector/browser_protocol.json

index 6527abc46147dfce17a799ed161709ebaff09425..c67f958a7726ed94f5ea9c0da24f4cdb3e75efe2 100644

--- a/third_party/WebKit/Source/core/inspector/browser_protocol.json

+++ b/third_party/WebKit/Source/core/inspector/browser_protocol.json

@@ -2525,7 +2525,8 @@

"name": "getNodeForLocation",

"parameters": [

{ "name": "x", "type": "integer", "description": "X coordinate." },

- { "name": "y", "type": "integer", "description": "Y coordinate." }

+ { "name": "y", "type": "integer", "description": "Y coordinate." },

+ { "name": "includeUserAgentShadowDOM", "type": "boolean", "optional": true, "description": "False to skip to the nearest non-UA shadow root ancestor (default: true)." }

pfeldman 2017/03/22 01:11:02 You should make it false by default, it is fine if

"returns": [

{ "name": "nodeId", "$ref": "NodeId", "description": "Id of the node at given coordinates." }