Allow DOM.getNodeForLocation to skip to nearest non-shadow ancestor

third_party/WebKit/Source/devtools/front_end/sdk/DOMModel.js

 /*
  * Copyright (C) 2009, 2010 Google Inc. All rights reserved.
  * Copyright (C) 2009 Joseph Pecoraro
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
@@ skipping 1811 matching lines @@
   setHighlighter(highlighter) {
     this._highlighter = highlighter || this._defaultHighlighter;
   }
 
   /**
    * @param {number} x
    * @param {number} y
    * @param {function(?SDK.DOMNode)} callback
    */
   nodeForLocation(x, y, callback) {
-    this._agent.getNodeForLocation(x, y, mycallback.bind(this));
+    var showUAShadowDOM = Common.moduleSetting('showUAShadowDOM').get();
+    this._agent.getNodeForLocation(x, y, showUAShadowDOM, mycallback.bind(this));

[peleg, 2017/03/22 06:29:03]

Is this what you had in mind for using moduleSetting?

[pfeldman, 2017/03/22 17:32:46]

I meant that you pass the boolean into DOMModel and fetch the setting on the
call site. showUAShadowDOM setting is defined in the elements module sdk does
not depend upon, so we should not use it here. We'll migrate to the scoped
settings at some point, but before that, we just need to be careful.

 
     /**
      * @param {?Protocol.Error} error
      * @param {number} nodeId
      * @this {SDK.DOMModel}
      */
     function mycallback(error, nodeId) {
       if (error) {
         callback(null);
         return;
@@ skipping 305 matching lines @@
   /**
    * @override
    * @param {!Protocol.Page.FrameId} frameId
    */
   highlightFrame(frameId) {
     this._agent.highlightFrame(
         frameId, Common.Color.PageHighlight.Content.toProtocolRGBA(),
         Common.Color.PageHighlight.ContentOutline.toProtocolRGBA());
   }
 };