Side by Side Diff
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Keyboard Shortcuts
File
u
:
up to issue
j
/
k
:
jump to file after / before current file
J
/
K
:
jump to next file with a comment after / before current file
Side-by-side diff
i
:
toggle intra-line diffs
e
:
expand all comments
c
:
collapse all comments
s
:
toggle showing all comments
n
/
p
:
next / previous diff chunk or comment
N
/
P
:
next / previous comment
<Up>
/
<Down>
:
next / previous line
Issue
u
:
up to list of issues
j
/
k
:
jump to patch after / before current patch
o
/
<Enter>
:
open current patch in side-by-side view
i
:
open current patch in unified diff view
Issue List
j
/
k
:
jump to issue after / before current issue
o
/
<Enter>
:
open current issue
Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr)
|
Please choose your nickname with
Settings
|
Help
|
Chromium Project
|
Gerrit Changes
|
Sign out
(71)
Issues
Search
My Issues
|
Starred
Open
|
Closed
|
All
Side by Side Diff: third_party/WebKit/LayoutTests/inspector-protocol/dom/dom-getNodeForLocation-skip-shadow-expected.txt
Issue
2763913002
:
Allow DOM.getNodeForLocation to skip to nearest non-shadow ancestor (Closed)
Patch Set: feedback
Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Context:
3 lines
10 lines
25 lines
50 lines
75 lines
100 lines
Whole file
Column Width:
Tab Spaces:
Jump to:
third_party/WebKit/LayoutTests/inspector-protocol/dom/dom-getNodeForLocation-skip-shadow.html
third_party/WebKit/LayoutTests/inspector-protocol/dom/dom-getNodeForLocation-skip-shadow-expected.txt
third_party/WebKit/Source/core/inspector/InspectorDOMAgent.h
third_party/WebKit/Source/core/inspector/InspectorDOMAgent.cpp
third_party/WebKit/Source/core/inspector/browser_protocol.json
third_party/WebKit/Source/core/inspector/browser_protocol-1.2.json
third_party/WebKit/Source/devtools/front_end/sdk/DOMModel.js
View unified diff
|
Download patch
« no previous file with comments
|
« third_party/WebKit/LayoutTests/inspector-protocol/dom/dom-getNodeForLocation-skip-shadow.html
('k') |
third_party/WebKit/Source/core/inspector/InspectorDOMAgent.h »
('j') |
third_party/WebKit/Source/core/inspector/browser_protocol-1.2.json »
('J')
Toggle Intra-line Diffs
('i') |
Expand Comments
('e') |
Collapse Comments
('c') |
Show Comments
Hide Comments
('s')
OLD
NEW
(Empty)
1
2
Node: {
3
attributes : [
4
[0] : type
5
[1] : text
6
[2] : style
7
[3] : position:absolute;top:0;left:0;width:100;height:100
8
]
9
backendNodeId : <number>
10
childNodeCount : 0
11
children : [
12
]
13
localName : input
14
nodeName : INPUT
15
nodeType : 1
16
nodeValue :
17
parentId : <number>
18
shadowRoots : [
19
[0] : {
20
backendNodeId : <number>
21
childNodeCount : 1
22
localName :
23
nodeId : <number>
24
nodeName : #document-fragment
25
nodeType : 11
26
nodeValue :
27
shadowRootType : user-agent
28
}
29
]
30
}
31
OLD
NEW
« no previous file with comments
|
« third_party/WebKit/LayoutTests/inspector-protocol/dom/dom-getNodeForLocation-skip-shadow.html
('k') |
third_party/WebKit/Source/core/inspector/InspectorDOMAgent.h »
('j') |
third_party/WebKit/Source/core/inspector/browser_protocol-1.2.json »
('J')
Issue 2763913002: Allow DOM.getNodeForLocation to skip to nearest non-shadow ancestor (Closed)
Created 3 years, 9 months ago by peleg
Modified 3 years, 9 months ago
Reviewers: pfeldman
Base URL:
Comments: 9
This is Rietveld
408576698