net/nqe/network_quality_estimator_params.cc - Issue 2763853002: Use Android callback API to obtain cellular signal strength

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/nqe/network_quality_estimator_params.cc

Issue 2763853002: Use Android callback API to obtain cellular signal strength (Closed)

Patch Set: pauljensen comments Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/nqe/network_quality_estimator_params.cc

diff --git a/net/nqe/network_quality_estimator_params.cc b/net/nqe/network_quality_estimator_params.cc

index ab4dc9c2bf933387bdcb57970df26608c665a567..fbc258e8429ffd9f5536af2c2738f0a2710e5e32 100644

--- a/net/nqe/network_quality_estimator_params.cc

+++ b/net/nqe/network_quality_estimator_params.cc

@@ -373,10 +373,11 @@ NetworkQualityEstimatorParams::NetworkQualityEstimatorParams(

"throughput_min_requests_in_flight",

1)),

weight_multiplier_per_second_(GetWeightMultiplierPerSecond(params_)),

- weight_multiplier_per_dbm_(

- GetDoubleValueForVariationParamWithDefaultValue(params_,

- "rssi_weight_per_dbm",

- 1.0)),

+ weight_multiplier_per_signal_strength_level_(

+ GetDoubleValueForVariationParamWithDefaultValue(

+ params_,

+ "rssi_weight_per_signal_strength_level",

+ 1.0)),

correlation_uma_logging_probability_(

GetDoubleValueForVariationParamWithDefaultValue(

params_,